From 1980f0877e5cff8e41ff3eafafe4c57133d7c899 Mon Sep 17 00:00:00 2001 From: Antoine Toulme Date: Tue, 21 Jan 2025 07:37:20 -0800 Subject: [PATCH] [chore] unexport type (#3636) --- internal/openshift/dashboards/dashboards.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/internal/openshift/dashboards/dashboards.go b/internal/openshift/dashboards/dashboards.go index a33ec03860..a2a2b69bad 100644 --- a/internal/openshift/dashboards/dashboards.go +++ b/internal/openshift/dashboards/dashboards.go @@ -22,6 +22,7 @@ import ( metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" v1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/client-go/kubernetes" + "sigs.k8s.io/controller-runtime/pkg/manager" ) // The dashboard is created manually following the syntax from Grafana 5. For development purposes, this dashboard can be created just by loading the JSON file @@ -35,17 +36,17 @@ const ( configMapName = "opentelemetry-collector" ) -type DashboardManagement struct { +type dashboardManagement struct { clientset kubernetes.Interface } -func NewDashboardManagement(clientset kubernetes.Interface) DashboardManagement { - return DashboardManagement{ +func NewDashboardManagement(clientset kubernetes.Interface) manager.Runnable { + return dashboardManagement{ clientset: clientset, } } -func (d DashboardManagement) Start(ctx context.Context) error { +func (d dashboardManagement) Start(ctx context.Context) error { cm := corev1.ConfigMap{ ObjectMeta: v1.ObjectMeta{ Name: configMapName, @@ -69,6 +70,6 @@ func (d DashboardManagement) Start(ctx context.Context) error { return d.clientset.CoreV1().ConfigMaps(openshiftDashboardsNamespace).Delete(ctx, configMapName, metav1.DeleteOptions{}) } -func (d DashboardManagement) NeedLeaderElection() bool { +func (d dashboardManagement) NeedLeaderElection() bool { return true }