Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings update needed - typings/angular2/angular2.d.ts still on alpha.26 #27

Closed
NathanWalker opened this issue Jul 15, 2015 · 5 comments

Comments

@NathanWalker
Copy link
Contributor

I believe the _custom typings folder is confusing and troublesome. When running tsd install it removes the _custom folder and will install correct typings for the latest commit specified in tsd.json...which for angular2 is: DefinitelyTyped/DefinitelyTyped@e29cf4c

I think the typings setup here just needs to be cleaned up and updated to help alleviate pain here?

@NathanWalker NathanWalker changed the title Typings update need - typings/angular2/angular2.d.ts still on alpha.26 Typings update needed - typings/angular2/angular2.d.ts still on alpha.26 Jul 15, 2015
@lBilali
Copy link

lBilali commented Jul 17, 2015

You can look at https://github.com/mgechev/angular2-seed for latest typings.
Seems like they have the ones for alpha.31

@PatrickJS
Copy link
Contributor

yo @NathanWalker, I changed the typing convention to

/src/typings/ custom typings
/src/typings/_custom.d.s main file to require everything
/src/typings/tsd.d.ts requires tsd_typings
/tsd_typings/ tsd typings (like node_modules these files live and generates at root level)

so far this is the best approach while also reinstalling tsd_typings on each npm install. I have a friend who is working on better tsd/typing management so this works for me until he is done
https://github.com/angular-class/angular2-webpack-starter

@NathanWalker
Copy link
Contributor Author

Thanks @gdi2290 for the suggestion 👍 That seems like a great way to go. I'll try updating this project to follow something similar.

NathanWalker pushed a commit to NathanWalker/angular2-authentication-sample that referenced this issue Jul 19, 2015
…ted by @gdi2290 here: auth0-blog#27 ... Fixed Http api to match latest change in alpha.31

closes auth0-blog#27
@NathanWalker
Copy link
Contributor Author

I've updated the PR here:
#26

...see comments there for further explanation of changes. Thanks again @gdi2290 , I hope more people can follow your pattern of managing Typings, seems really clean and smart to me.

@chenkie
Copy link
Contributor

chenkie commented Jan 8, 2016

Updated to beta 0

@chenkie chenkie closed this as completed Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants