Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asterisk import syntax for import all #2189

Closed
wants to merge 4 commits into from

Conversation

tstirrat15
Copy link
Contributor

Description

This is intended to provide an escape hatch for users who don't want to explicitly list all of the imports they're bringing in from a source file. It should make explicit import behavior less painful in some cases as well, and is intended as a compromise between implicit and explicit import syntax.

Changes

  • Add * syntax for imports to say "import everything"
  • Add tests for that syntax
  • Add predicate as marker on the node

Testing

Review. See that tests pass.

@tstirrat15 tstirrat15 marked this pull request as ready for review January 4, 2025 00:18
@tstirrat15 tstirrat15 requested a review from a team as a code owner January 4, 2025 00:18
@tstirrat15 tstirrat15 force-pushed the add-asterisk-import-syntax branch from 2008990 to 9c6bcc3 Compare January 4, 2025 00:18
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Jan 4, 2025
@tstirrat15
Copy link
Contributor Author

Pausing this pending a design discussion. It'll probably be closed.

@tstirrat15
Copy link
Contributor Author

We're going a different direction.

@tstirrat15 tstirrat15 closed this Jan 15, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant