ci: enable E602 pylint rule (#6616)

Remove E0602 as ignore items when running code lint check. It was
accidently added to the ignore list but E0602 is important when
doing code check therefore it should not be ignored. I have also update
relevant .py source files to correct the code.

Signed-off-by: Haijiao Zhao <[email protected]>

Author: chloerh

.github/workflows/ci.yml

@@ -36,7 +36,7 @@ jobs:
          pip install sphinx${SPHINX_VERSION:+==$SPHINX_VERSION}
          pip install -r requirements-travis.txt
       - name: Run inspekt
-        run: inspekt checkall --disable-style E501,E265,W601,W605,E402,E722,E741 --disable-lint W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0601,E0602,E0606 --no-license-check
+        run: inspekt checkall --disable-style E501,E265,W601,W605,E402,E722,E741 --disable-lint W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E0601,E0606 --no-license-check
       - run: echo "This job's status is ${{ job.status }}."
       - name: Run spellchecker
         run: |

libvirt/tests/src/passthrough/ccw/libvirt_ccw_passthrough.py

@@ -1,3 +1,4 @@
+import logging
 from uuid import uuid4
 
 from virttest.utils_misc import wait_for, cmd_status_output
@@ -6,6 +7,8 @@
 
 from provider.vfio import ccw
 
+LOG = logging.getLogger('avocado.' + __name__)
+
 
 def mdev_listed(uuid):
     """

libvirt/tests/src/scsi/scsi_controller_driver_queues.py

@@ -56,7 +56,7 @@ def check_result():
                               "but found '%s'." % (expect_value, dev.driver.get("queues")))
                 if actual_driver_iothreads != driver_iothreads:
                     test.fail("Expect the scsi controller iothread to be '%s',"
-                              "but found '%s'." % (driver_iothreads, actual_driver.iothreads))
+                              "but found '%s'." % (driver_iothreads, actual_driver_iothreads))
         test.log.info("TEST_STEP3: check the qemu command line.")
         if check_qemu_pattern:
             libvirt.check_qemu_cmd_line(check_qemu_pattern)

libvirt/tests/src/virsh_cmd/domain/virsh_sosreport.py

@@ -1,8 +1,8 @@
 import logging
 import os
+import re
 import shutil
 import subprocess
-
 from pathlib import Path
 
 

libvirt/tests/src/virsh_cmd/volume/virsh_vol_download_upload.py

@@ -258,7 +258,7 @@ def run(test, params, env):
         if pool_type is not None:
             options = " --pool %s" % pool_name
         if offset is not None:
-            options += " --offset %s" % offset
+            options += " --offset %s" % offset  # pylint: disable=E0602
             offset = int(offset)
         else:
             offset = 0

libvirt/tests/src/virsh_cmd/volume/virsh_vol_resize.py

@@ -8,6 +8,7 @@
 from avocado.core import exceptions
 
 from virttest import libvirt_storage
+from virttest import utils_sys
 from virttest import utils_misc
 from virttest import utils_split_daemons
 from virttest import virsh

libvirt/tests/src/virtiofs/virtiofs.py

@@ -6,6 +6,7 @@
 
 from glob import glob
 
+from aexpect import ShellTimeoutError
 from avocado.utils import process
 from avocado.utils import path as utils_path