Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter preview to just show site root, when clicking open preview #85

Closed
pmuir opened this issue Oct 25, 2013 · 7 comments
Closed

Alter preview to just show site root, when clicking open preview #85

pmuir opened this issue Oct 25, 2013 · 7 comments
Assignees

Comments

@pmuir
Copy link
Contributor

pmuir commented Oct 25, 2013

No description provided.

@ghost ghost assigned wesbos Oct 25, 2013
@LightGuard
Copy link
Member

I believe my comments in #86 also applies here.

@wesbos
Copy link
Member

wesbos commented Oct 29, 2013

Just to refresh memories, we talked about this last week in Austin.

We will show the user the site root and then allow them to navigate to the page that they desire. When we re-generate the site, we should simply refresh that page rather than replacing the HTML.

@LightGuard It's possible to get a URL for the generated site, correct? Right now we just get HTML and I place it into the document.

@LightGuard
Copy link
Member

Actually if you just brows to /preview/repo it will show you the root of
the site right now.

On Tue, Oct 29, 2013 at 2:35 PM, Wes Bos [email protected] wrote:

Just to refresh memories, we talked about this last week in Austin.

We will show the user the site root and then allow them to navigate to the
page that they desire. When we re-generate the site, we should simply
refresh that page rather than replacing the HTML.

@LightGuard https://github.com/LightGuard It's possible to get a URL
for the generated site, correct? Right now we just get HTML and I place it
into the document.


Reply to this email directly or view it on GitHubhttps://github.com//issues/85#issuecomment-27340927
.

Jason Porter
http://en.gravatar.com/lightguardjp

@wesbos
Copy link
Member

wesbos commented Oct 29, 2013

Perfect!

@pmuir
Copy link
Contributor Author

pmuir commented Oct 30, 2013

I was wondering if the best approach here would be to continue opening the specific page, as we do now, but have a link in the footer "Preview home page" to allow them to navigate there in the preview? This would avoid the problem where they get trapped in the wrong place, but keep the nice ability to preview the most recent page without extra clicks.

@LightGuard
Copy link
Member

With what we spoke about yesterday and the sections of a page, that's
doable now.

On Wed, Oct 30, 2013 at 3:29 AM, Pete Muir [email protected] wrote:

I was wondering if the best approach here would be to continue opening the
specific page, as we do now, but have a link in the footer "Preview home
page" to allow them to navigate there in the preview? This would avoid the
problem where they get trapped in the wrong place, but keep the nice
ability to preview the most recent page without extra clicks.


Reply to this email directly or view it on GitHubhttps://github.com//issues/85#issuecomment-27374996
.

Jason Porter
http://en.gravatar.com/lightguardjp

@wesbos
Copy link
Member

wesbos commented Dec 3, 2013

Closing this as it has now been implemented.

@wesbos wesbos closed this as completed Dec 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants