From db43cb0a2edeee75621d5598e4c7a0ecde12b541 Mon Sep 17 00:00:00 2001 From: HSTE21 <160339139+HSTE21@users.noreply.github.com> Date: Sun, 2 Nov 2025 14:28:46 +0100 Subject: [PATCH] fix(setup): Update Physionet 2017 challenge download links MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### ๐Ÿ”จ Motivation The original download links used in `setup.sh` for the Physionet Challenge 2017 data were broken and failed to complete the script's execution. This prevented users from successfully setting up the necessary training and sample datasets. ### โœ… Changes This pull request updates the `setup.sh` file with the new, working, direct download URLs for the following files: * `training2017.zip` * `sample2017.zip` * `REFERENCE-v3.csv` The script now uses the direct `?download` links from PhysioNet, ensuring the setup process completes successfully. ### ๐Ÿงช Testing The updated `setup.sh` script was executed locally to confirm that: 1. The `data` directory is created. 2. All three files (`training2017.zip`, `sample2017.zip`, `REFERENCE-v3.csv`) are downloaded correctly. 3. The two zip files are successfully unzipped. 4. The script proceeds to the final step (`python build_datasets.py`) without errors. --- examples/cinc17/setup.sh | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/examples/cinc17/setup.sh b/examples/cinc17/setup.sh index 7d2fd311..81e05fc4 100755 --- a/examples/cinc17/setup.sh +++ b/examples/cinc17/setup.sh @@ -1,14 +1,19 @@ #!/bin/bash -url=https://www.physionet.org/challenge/2017/ +# The original base URL no longer works, we are using direct links. mkdir data && cd data -curl -O $url/training2017.zip +# Download training data +curl -L -o training2017.zip "https://www.physionet.org/files/challenge-2017/1.0.0/training2017.zip?download" unzip training2017.zip -curl -O $url/sample2017.zip + +# Download sample data +curl -L -o sample2017.zip "https://www.physionet.org/files/challenge-2017/1.0.0/sample2017.zip?download" unzip sample2017.zip -curl -O $url/REFERENCE-v3.csv + +# Download reference file (NOTE: this is called REFERENCE-v3.csv) +curl -L -o REFERENCE-v3.csv "https://www.physionet.org/files/challenge-2017/1.0.0/REFERENCE-v3.csv?download" cd ..