Make FileSystem's field Backup a No-Op (#29)

Issue [#2182](aws-controllers-k8s/community#2182)

Description of changes:
Backup field is used during creation of an EFS File System, 
and nowhere else. For Find and Update, the API instead uses 
a BackupPolicy field.
Moving forward the ACK controller will return a Terminal error
when the Backup field is defined, and instead we will only be accepting 
backup configurations through the backupPolicy field.

I am choosing sdkFind to return this failure since it's the funtion 
that is called after each event that happens to a resource.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: michaelhtm

apis/v1alpha1/ack-generate-metadata.yaml

@@ -7,7 +7,7 @@ api_directory_checksum: ebeb6f826282ad9134ca78efd74dc9125898fddf
 api_version: v1alpha1
 aws_sdk_go_version: v1.32.6
 generator_config_info:
-  file_checksum: 04422334db0c3aa480faf9a643b0dd1e4ae05c21
+  file_checksum: 56ea3e58543a7b3a26ef07a8c2cd6277d59bdf6f
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -26,6 +26,11 @@ controller_name: efs
 resources:
   FileSystem:
     fields:
+      Backup:
+        compare:
+          is_ignored: true
+        set:
+        - ignore: all
       KMSKeyID:
         references:
           resource: Key
@@ -61,6 +66,8 @@ resources:
         template_path: hooks/file_system/sdk_read_many_post_set_output.go.tpl
       sdk_update_pre_build_request:
         template_path: hooks/file_system/sdk_update_pre_build_request.go.tpl
+      sdk_read_many_pre_build_request:
+        template_path: hooks/file_system/sdk_read_many_pre_build_request.go.tpl
     print:
       add_age_column: true
       add_synced_column: true

generator.yaml

@@ -26,6 +26,11 @@ controller_name: efs
 resources:
   FileSystem:
     fields:
+      Backup:
+        compare:
+          is_ignored: true
+        set:
+        - ignore: all
       KMSKeyID:
         references:
           resource: Key
@@ -61,6 +66,8 @@ resources:
         template_path: hooks/file_system/sdk_read_many_post_set_output.go.tpl
       sdk_update_pre_build_request:
         template_path: hooks/file_system/sdk_update_pre_build_request.go.tpl
+      sdk_read_many_pre_build_request:
+        template_path: hooks/file_system/sdk_read_many_pre_build_request.go.tpl
     print:
       add_age_column: true
       add_synced_column: true

pkg/resource/file_system/delta.go

@@ -242,12 +242,17 @@ func (rm *resourceManager) syncBackupPolicy(ctx context.Context, r *resource) (e
 	exit := rlog.Trace("rm.syncBackupPolicy")
 	defer func() { exit(err) }()
 
+	status := svcsdktypes.StatusDisabled
+	if r.ko.Spec.BackupPolicy != nil && r.ko.Spec.BackupPolicy.Status != nil {
+		status = svcsdktypes.Status(*r.ko.Spec.BackupPolicy.Status)
+	}
+
 	_, err = rm.sdkapi.PutBackupPolicy(
 		ctx,
 		&svcsdk.PutBackupPolicyInput{
 			FileSystemId: r.ko.Status.FileSystemID,
 			BackupPolicy: &svcsdktypes.BackupPolicy{
-				Status: svcsdktypes.Status(*r.ko.Spec.BackupPolicy.Status),
+				Status: status,
 			},
 		},
 	)

pkg/resource/file_system/hooks.go

@@ -0,0 +1,4 @@
+	if r.ko.Spec.Backup != nil {
+		msg := fmt.Errorf("field Backup is a NO-OP field. Set BackupPolicy.Status instead")
+		return nil, ackerr.NewTerminalError(msg)
+	}