Skip to content

Commit 31e4979

Browse files
authored
Ignore tag comparison for Identity provider config (#117)
tag update is not supported by identity provider config resource api. EKS controller tries to update the default tags like `services.k8s.aws/controller-version` whenever controller version changes. This results in controller errors. Since tag update is not supported by the apis, this fix ignores the tag comparison and thereby would never try to update tags.
1 parent 4f9d6fc commit 31e4979

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2024-05-28T22:22:45Z"
2+
build_date: "2024-06-06T04:13:17Z"
33
build_hash: 14cef51778d471698018b6c38b604181a6948248
44
go_version: go1.21.1
55
version: v0.34.0
66
api_directory_checksum: 626700f8799840e0470b1ff7ef3dbb32665b9f9d
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.49.13
99
generator_config_info:
10-
file_checksum: 3e2332beafd7d7b5898a51082c0e96d9594775bb
10+
file_checksum: c6dada6a685b8ed90112dab66773cc94314dd2b8
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,8 @@ resources:
101101
path: IdentityProviderConfig.Oidc.Status
102102
Tags:
103103
is_immutable: true
104+
compare:
105+
is_ignored: true
104106
hooks:
105107
sdk_delete_post_build_request:
106108
template_path: hooks/identity_provider_config/sdk_delete_post_build_request.go.tpl

generator.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,8 @@ resources:
101101
path: IdentityProviderConfig.Oidc.Status
102102
Tags:
103103
is_immutable: true
104+
compare:
105+
is_ignored: true
104106
hooks:
105107
sdk_delete_post_build_request:
106108
template_path: hooks/identity_provider_config/sdk_delete_post_build_request.go.tpl

pkg/resource/identity_provider_config/delta.go

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)