When db instance is inside db cluster(when DBClusterIdentifier appear), set cluster level params to nil (#99)

* Set some params to nil when dbInstance is an clustered instance

* Update comment a little bit

Co-authored-by: Tenglong Gu <[email protected]>

Author: brucegucode

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,7 +1,7 @@
 ack_generate_info:
-  build_date: "2022-07-11T19:31:21Z"
+  build_date: "2022-07-11T21:43:34Z"
   build_hash: d09bac5fa87cffd0028014833a5e7e786c0187dd
-  go_version: go1.18.3
+  go_version: go1.18.2
   version: v0.19.2-6-gd09bac5
 api_directory_checksum: a60467e94dc7e76bf34ff50f21691507d576fefc
 api_version: v1alpha1

pkg/resource/db_instance/sdk.go

@@ -24,3 +24,15 @@
         if !delta.DifferentAt("Spec.NetworkType") {
                 input.NetworkType = nil
         }
+
+        // For dbInstance inside dbCluster, it's either aurora or 
+        // multi-az cluster case, in either case, the below params
+        // are not controlled in instance level. 
+        // hence when DBClusterIdentifier appear, set them to nil
+        // Please refer to doc : https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DeleteDBInstance.html 
+        if desired.ko.Spec.DBClusterIdentifier != nil {
+                input.AllocatedStorage = nil
+                input.BackupRetentionPeriod = nil
+                input.PreferredBackupWindow = nil
+                input.DeletionProtection = nil
+        }