Bring in ACK runtime v0.15.2 (#49)

Regenerates the rds-controller with the latest v0.15.2 runtime.

**BREAKING CHANGES**:

The DBInstance's Spec.DBSecurityGroupNames field is now renamed to just
Spec.DBSecurityGroups. It continues to be a `[]*string` field but now
the rds-controller correctly handles comparisons for this fields value
with the returned latest observed state.

Includes changes to the generator.yaml file that instructs the
code-generator how to handle the DBSecurityGroups field on DBInstance.

Signed-off-by: Jay Pipes <[email protected]>

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

Author: jaypipes

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2021-10-21T19:35:08Z"
-  build_hash: 21ee1672e2c1556fd5784a22bc48aa619975cc6f
-  go_version: go1.17.1
-  version: v0.15.1
-api_directory_checksum: cd0469d4474d82dbcf9badb97a43cac68ba07044
+  build_date: "2021-11-18T15:25:36Z"
+  build_hash: 966e9a9ac6dfb4bbc2d3ded1972ce2b706391d44
+  go_version: go1.17
+  version: v0.15.2
+api_directory_checksum: cae902b75e1b0827659c4bfe7ef9f6bb98769f5c
 api_version: v1alpha1
 aws_sdk_go_version: v1.37.10
 generator_config_info:
-  file_checksum: e99b7e3e4ce6b046e2aabcc164c99bc920272c4d
+  file_checksum: a40f829b03389cf1b2a003ebe2a79b97bc9d3322
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/db_instance.go

@@ -126,14 +126,6 @@ resources:
         template_path: hooks/db_instance/sdk_update_pre_build_request.go.tpl
       sdk_delete_pre_build_request:
         template_path: hooks/db_instance/sdk_delete_pre_build_request.go.tpl
-    renames:
-      operations:
-        CreateDBInstance:
-          input_fields:
-            # The data type of the create input and create output shape of the
-            # DBSecurityGroups field is different which causes errors when
-            # compiling
-            DBSecurityGroups: DBSecurityGroupNames
     exceptions:
       terminal_codes:
         - InvalidParameter
@@ -144,8 +136,23 @@ resources:
         - DBSubnetGroupNotFoundFault
         - DBParameterGroupNotFound
     fields:
+      AvailabilityZone:
+        late_initialize: {}
       DBInstanceIdentifier:
         is_primary_key: true
+      # Because the Create input and Create/Update/ReadOne output shapes for
+      # the DBSecurityGroups field have different Go types, we are instructing
+      # the code generator to set the Spec.DBSecurityGroups field (which is a
+      # []string field) to the set of DBSecurityGroups..DBSecurityGroupName
+      # values in the ReadOne method's Output shape.
+      DBSecurityGroups:
+        set:
+          - method: Update
+            from: DBSecurityGroupName
+          - method: Create
+            from: DBSecurityGroupName
+          - method: ReadOne
+            from: DBSecurityGroupName
       MasterUserPassword:
         is_secret: true
   GlobalCluster:

apis/v1alpha1/generator.yaml

@@ -183,7 +183,7 @@ spec:
                   \n    * First character must be a letter \n    * Can't end with
                   a hyphen or contain two consecutive hyphens"
                 type: string
-              dbSecurityGroupNames:
+              dbSecurityGroups:
                 description: "A list of DB security groups to associate with this
                   DB instance. \n Default: The default DB security group for the database
                   engine."

apis/v1alpha1/zz_generated.deepcopy.go

@@ -126,14 +126,6 @@ resources:
         template_path: hooks/db_instance/sdk_update_pre_build_request.go.tpl
       sdk_delete_pre_build_request:
         template_path: hooks/db_instance/sdk_delete_pre_build_request.go.tpl
-    renames:
-      operations:
-        CreateDBInstance:
-          input_fields:
-            # The data type of the create input and create output shape of the
-            # DBSecurityGroups field is different which causes errors when
-            # compiling
-            DBSecurityGroups: DBSecurityGroupNames
     exceptions:
       terminal_codes:
         - InvalidParameter
@@ -148,6 +140,19 @@ resources:
         late_initialize: {}
       DBInstanceIdentifier:
         is_primary_key: true
+      # Because the Create input and Create/Update/ReadOne output shapes for
+      # the DBSecurityGroups field have different Go types, we are instructing
+      # the code generator to set the Spec.DBSecurityGroups field (which is a
+      # []string field) to the set of DBSecurityGroups..DBSecurityGroupName
+      # values in the ReadOne method's Output shape.
+      DBSecurityGroups:
+        set:
+          - method: Update
+            from: DBSecurityGroupName
+          - method: Create
+            from: DBSecurityGroupName
+          - method: ReadOne
+            from: DBSecurityGroupName
       MasterUserPassword:
         is_secret: true
   GlobalCluster:

config/crd/bases/rds.services.k8s.aws_dbinstances.yaml

@@ -3,7 +3,7 @@ module github.com/aws-controllers-k8s/rds-controller
 go 1.14
 
 require (
-	github.com/aws-controllers-k8s/runtime v0.15.1
+	github.com/aws-controllers-k8s/runtime v0.15.2
 	github.com/aws/aws-sdk-go v1.37.10
 	github.com/go-logr/logr v0.1.0
 	github.com/spf13/pflag v1.0.5

generator.yaml

@@ -23,8 +23,8 @@ github.com/andreyvit/diff v0.0.0-20170406064948-c7f18ee00883/go.mod h1:rCTlJbsFo
 github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod h1:grANhF5doyWs3UAsr3K4I6qtAmlQcZDesFNEHPZAzj8=
 github.com/asaskevich/govalidator v0.0.0-20180720115003-f9ffefc3facf/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY=
 github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY=
-github.com/aws-controllers-k8s/runtime v0.15.1 h1:3P+6MKWe8ITJynmoxmDnMPlkoI9nuVgn8XD9Pt/XHE8=
-github.com/aws-controllers-k8s/runtime v0.15.1/go.mod h1:W0Txdhb1Npx5kg72w2WFwIpGFvSsMxXlJzzNHAwCLeY=
+github.com/aws-controllers-k8s/runtime v0.15.2 h1:waRPQGw+b/9huNHcMG+LQoVW4VP2YIBqZNdB+JAh//E=
+github.com/aws-controllers-k8s/runtime v0.15.2/go.mod h1:W0Txdhb1Npx5kg72w2WFwIpGFvSsMxXlJzzNHAwCLeY=
 github.com/aws/aws-sdk-go v1.37.10 h1:LRwl+97B4D69Z7tz+eRUxJ1C7baBaIYhgrn5eLtua+Q=
 github.com/aws/aws-sdk-go v1.37.10/go.mod h1:hcU610XS61/+aQV88ixoOzUoG7v3b31pl2zKMmprdro=
 github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod h1:Dwedo/Wpr24TaqPxmxbtue+5NUziq4I4S80YR8gNf3Q=

go.mod

@@ -183,7 +183,7 @@ spec:
                   \n    * First character must be a letter \n    * Can't end with
                   a hyphen or contain two consecutive hyphens"
                 type: string
-              dbSecurityGroupNames:
+              dbSecurityGroups:
                 description: "A list of DB security groups to associate with this
                   DB instance. \n Default: The default DB security group for the database
                   engine."