Skip to content

Commit f78df97

Browse files
authored
release artifacts for v0.0.4 (#11)
When running make build-controller, the `scripts/build-controller.sh` script in `github.com/aws-controllers-k8s/code-generator` apparently [copies][0] all of the static files in the code-generator into the target service controller repository. That is why you see the changes to the NOTICE/CONTRIBUTING.md files, etc. [0]: https://github.com/aws-controllers-k8s/code-generator/blob/e661ce95afc39b380653ca655503daebf1e1831b/scripts/build-controller.sh#L231-L236 Signed-off-by: Jay Pipes <[email protected]> By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 51f5c48 commit f78df97

File tree

8 files changed

+75
-38
lines changed

8 files changed

+75
-38
lines changed

CONTRIBUTING.md

Lines changed: 50 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,59 +1,85 @@
11
# Contributing Guidelines
22

3-
Thank you for your interest in contributing to our project. Whether it's a bug report, new feature, correction, or additional
4-
documentation, we greatly value feedback and contributions from our community.
5-
6-
Please read through this document before submitting any issues or pull requests to ensure we have all the necessary
7-
information to effectively respond to your bug report or contribution.
3+
Thank you for your interest in contributing to our project. Whether it's a bug
4+
report, new feature, correction, or additional documentation, we greatly value
5+
feedback and contributions from our community.
86

7+
Please read through this document before submitting any issues or pull requests
8+
to ensure we have all the necessary information to effectively respond to your
9+
bug report or contribution.
910

1011
## Reporting Bugs/Feature Requests
1112

12-
We welcome you to use the GitHub issue tracker to report bugs or suggest features.
13+
We welcome you to use the GitHub issue tracker to report bugs or suggest
14+
features.
1315

14-
When filing an issue, please check existing open, or recently closed, issues to make sure somebody else hasn't already
15-
reported the issue. Please try to include as much information as you can. Details like these are incredibly useful:
16+
When filing an issue, please check existing open, or recently closed, issues to
17+
make sure somebody else hasn't already reported the issue. Please try to
18+
include as much information as you can. Details like these are incredibly
19+
useful:
1620

1721
* A reproducible test case or series of steps
1822
* The version of our code being used
1923
* Any modifications you've made relevant to the bug
2024
* Anything unusual about your environment or deployment
2125

22-
2326
## Contributing via Pull Requests
24-
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
27+
28+
Contributions via pull requests are much appreciated. Before sending us a pull
29+
request, please ensure that:
2530

2631
1. You are working against the latest source on the *main* branch.
27-
2. You check existing open, and recently merged, pull requests to make sure someone else hasn't addressed the problem already.
28-
3. You open an issue to discuss any significant work - we would hate for your time to be wasted.
32+
2. You check existing open, and recently merged, pull requests to make sure
33+
someone else hasn't addressed the problem already.
34+
3. You open an issue to discuss any significant work - we would hate for your
35+
time to be wasted.
2936

3037
To send us a pull request, please:
3138

3239
1. Fork the repository.
33-
2. Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
40+
2. Modify the source; please focus on the specific change you are contributing.
41+
If you also reformat all the code, it will be hard for us to focus on your
42+
change.
3443
3. Ensure local tests pass.
3544
4. Commit to your fork using clear commit messages.
36-
5. Send us a pull request, answering any default questions in the pull request interface.
37-
6. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.
45+
5. Send us a pull request, answering any default questions in the pull request
46+
interface.
47+
6. Pay attention to any automated CI failures reported in the pull request, and
48+
stay involved in the conversation.
3849

39-
GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and
40-
[creating a pull request](https://help.github.com/articles/creating-a-pull-request/).
50+
GitHub provides additional document on [forking a repository][fork] and
51+
[creating a pull request][pr].
4152

53+
[fork]: https://help.github.com/articles/fork-a-repo/
54+
[pr]: https://help.github.com/articles/creating-a-pull-request/
4255

4356
## Finding contributions to work on
44-
Looking at the existing issues is a great way to find something to contribute on. As our projects, by default, use the default GitHub issue labels (enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at any 'help wanted' issues is a great place to start.
4557

58+
Looking at the existing issues is a great way to find something to contribute
59+
on. As our projects, by default, use the default GitHub issue labels
60+
(enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at
61+
any 'help wanted' issues is a great place to start.
62+
63+
## Developer documentation
64+
65+
[See the documentation][dev-docs] for detailed development information.
66+
67+
[dev-docs]: https://aws-controllers-k8s.github.io/community/docs/contributor-docs/overview/
4668

4769
## Code of Conduct
48-
This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
49-
For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
50-
[email protected] with any additional questions or comments.
5170

71+
We adhere to the [Amazon Open Source Code of Conduct][coc].
72+
73+
[coc]: https://aws.github.io/code-of-conduct
5274

5375
## Security issue notifications
54-
If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public github issue.
5576

77+
If you discover a potential security issue in this project we ask that you
78+
notify AWS/Amazon Security via our [vulnerability reporting page][vuln]. Please
79+
do **not** create a public Github issue.
80+
81+
[vuln]: http://aws.amazon.com/security/vulnerability-reporting/
5682

57-
## Licensing
83+
## License
5884

59-
See the [LICENSE](/LICENSE) file for our project's licensing. We will ask you to confirm the licensing of your contribution.
85+
This project is [licensed][./LICENSE] under the Apache-2.0 License.

GOVERNANCE.md

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,30 @@
11
# Project governance
22

3-
This document lays out the guidelines under which the AWS Controllers for Kubernetes (ACK) project will be governed.
3+
This document lays out the guidelines under which the AWS Controllers for Kubernetes (ACK) project will be governed.
44
The goal is to make sure that the roles and responsibilities are well defined and clarify on how decisions are made.
55

6+
## Roles
7+
8+
In the context of ACK, we consider the following roles:
9+
10+
* __Users__ ... everyone using ACK, typically willing to provide feedback on ACK by proposing features and/or filing issues.
11+
* __Contributors__ ... everyone contributing code, documentation, examples, testing infra, and participating in feature proposals as well as design discussions. Code contributions will require a Developer Certificate of Origin (DCO).
12+
* __Maintainers__ ... are responsible for engaging with and assisting contributors to iterate on the contributions until it reaches acceptable quality. Maintainers can decide whether the contributions can be accepted into the project or rejected. Any active contributor meeting the project quality can be made a Maintainer by the Advisory Board.
13+
* __Advisory Board__ ... is responsible for defining the guidelines and processes that the project operates under.
14+
15+
The initial members of the Advisory Board are `@jaypipes` and `@mhausenblas`.
16+
17+
618
## Communication
719

8-
The primary mechanism for communication will be via the `#provider-aws` channel on the Kubernetes Slack community.
20+
The primary mechanism for communication will be via the `#provider-aws` channel on the Kubernetes Slack community.
921
All features and bug fixes will be tracked as issues in GitHub. All decisions will be documented in GitHub issues.
1022

11-
In the future, we may consider using a public mailing list, which can be better archived.
23+
In the future, we may consider using a public mailing list, which can be better archived.
1224

1325
## Roadmap Planning
1426

15-
Maintainers will share roadmap and release versions as milestones in GitHub.
27+
Maintainers will share roadmap and release versions as milestones in GitHub.
1628

1729
## Release Management
1830

NOTICE

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
2-
1+
Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.

apis/v1alpha1/ack-generate-metadata.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
ack_generate_info:
2-
build_date: "2022-12-13T18:11:00Z"
3-
build_hash: 4aeb2feebfb87ad9c79fcdf02997355de66e228d
2+
build_date: "2022-12-16T20:24:15Z"
3+
build_hash: e661ce95afc39b380653ca655503daebf1e1831b
44
go_version: go1.18.1
5-
version: v0.21.0-6-g4aeb2fe
5+
version: v0.21.0-5-ge661ce9
66
api_directory_checksum: a0c05230761bda067a0f03b794041014296b8bcb
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.44.93

config/controller/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ kind: Kustomization
66
images:
77
- name: controller
88
newName: public.ecr.aws/aws-controllers-k8s/sns-controller
9-
newTag: v0.0.0-non-release-version
9+
newTag: v0.0.4

helm/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
apiVersion: v1
22
name: sns-chart
33
description: A Helm chart for the ACK service controller for Amazon Simple Notification Service (SNS)
4-
version: v0.0.0-non-release-version
5-
appVersion: v0.0.0-non-release-version
4+
version: v0.0.4
5+
appVersion: v0.0.4
66
home: https://github.com/aws-controllers-k8s/sns-controller
77
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
88
sources:

helm/templates/NOTES.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{{ .Chart.Name }} has been installed.
2-
This chart deploys "public.ecr.aws/aws-controllers-k8s/sns-controller:v0.0.0-non-release-version".
2+
This chart deploys "public.ecr.aws/aws-controllers-k8s/sns-controller:v0.0.4".
33

44
Check its status by running:
55
kubectl --namespace {{ .Release.Namespace }} get pods -l "app.kubernetes.io/instance={{ .Release.Name }}"

helm/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
image:
66
repository: public.ecr.aws/aws-controllers-k8s/sns-controller
7-
tag: v0.0.0-non-release-version
7+
tag: v0.0.4
88
pullPolicy: IfNotPresent
99
pullSecrets: []
1010

0 commit comments

Comments
 (0)