Skip to content

Commit 5f7ef7b

Browse files
authored
add terminal errors (#98)
Issue [#2724](aws-controllers-k8s/community#2724) Description of changes: Set SQS error codes as Terminal errors. We want to set these error codes as terminal errors, since they require the user to change the spec when these errors are returned from SQS By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 4104a06 commit 5f7ef7b

File tree

6 files changed

+42
-7
lines changed

6 files changed

+42
-7
lines changed
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2025-12-11T23:39:26Z"
3-
build_hash: 5c8b9050006ef6c7d3a97c279e7b1bc163f20a0a
2+
build_date: "2025-12-23T20:35:23Z"
3+
build_hash: 43713d4546b29b09ac85cbb3da854425045237bd
44
go_version: go1.25.4
5-
version: v0.56.0-3-g5c8b905
5+
version: v0.56.0-4-g43713d4
66
api_directory_checksum: 2627dc306e3a83c86c04050c6c4336451459e728
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.32.6
99
generator_config_info:
10-
file_checksum: 7d19f3bad5c4ff9efc3550284a2e9284212afb28
10+
file_checksum: 022a45cf8564ebeaeb4fee6816d3a1bf540046bf
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ resources:
44
errors:
55
404:
66
code: AWS.SimpleQueueService.NonExistentQueue
7+
terminal_codes:
8+
- InvalidAttributeName
9+
- InvalidAttributeValue
10+
- InvalidParameterValue
11+
- InvalidParameterCombination
712
unpack_attributes_map:
813
set_attributes_single_attribute: false
914
get_attributes_input:

config/crd/common/bases/services.k8s.aws_iamroleselectors.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,16 @@ spec:
6363
required:
6464
- names
6565
type: object
66+
resourceLabelSelector:
67+
description: LabelSelector is a label query over a set of resources.
68+
properties:
69+
matchLabels:
70+
additionalProperties:
71+
type: string
72+
type: object
73+
required:
74+
- matchLabels
75+
type: object
6676
resourceTypeSelector:
6777
items:
6878
properties:

config/crd/common/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
apiVersion: kustomize.config.k8s.io/v1beta1
44
kind: Kustomization
55
resources:
6-
- bases/services.k8s.aws_iamroleselectors.yaml
76
- bases/services.k8s.aws_fieldexports.yaml
7+
- bases/services.k8s.aws_iamroleselectors.yaml

generator.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ resources:
44
errors:
55
404:
66
code: AWS.SimpleQueueService.NonExistentQueue
7+
terminal_codes:
8+
- InvalidAttributeName
9+
- InvalidAttributeValue
10+
- InvalidParameterValue
11+
- InvalidParameterCombination
712
unpack_attributes_map:
813
set_attributes_single_attribute: false
914
get_attributes_input:

pkg/resource/queue/sdk.go

Lines changed: 17 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)