Skip to content

Commit 320d849

Browse files
committed
fix in makefile to always create build-dir
1 parent 7ab5262 commit 320d849

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

Makefile

+12-10
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,12 @@ BUILD_DIR_PATH = ${MAKEFILE_PATH}/build
1313
SUPPORTED_PLATFORMS ?= "windows/amd64,darwin/amd64,linux/amd64,linux/arm64,linux/arm"
1414
SELECTOR_PKG_VERSION_VAR=github.com/aws/amazon-ec2-instance-selector/pkg/selector.versionID
1515

16+
$(shell mkdir -p ${BUILD_DIR_PATH} && touch ${BUILD_DIR_PATH}/_go.mod)
17+
1618
compile:
1719
@echo ${MAKEFILE_PATH}
1820
go build -a -ldflags "-X main.versionID=${VERSION} -X ${SELECTOR_PKG_VERSION_VAR}=${VERSION}" -tags="aeis${GOOS}" -o ${BUILD_DIR_PATH}/${BIN} ${MAKEFILE_PATH}/cmd/main.go
1921

20-
create-build-dir:
21-
mkdir -p ${BUILD_DIR_PATH} && touch ${BUILD_DIR_PATH}/_go.mod
22-
2322
clean:
2423
rm -rf ${BUILD_DIR_PATH}/ && go clean -testcache ./...
2524

@@ -59,27 +58,30 @@ spellcheck:
5958
${MAKEFILE_PATH}/test/readme-test/run-readme-spellcheck
6059

6160
## requires aws credentials
62-
readme-codeblock-test:
61+
readme-codeblock-test:
6362
${MAKEFILE_PATH}/test/readme-test/run-readme-codeblocks
6463

65-
output-validation-test: create-build-dir
64+
## requires aws credentials
65+
output-validation-test:
6666
${MAKEFILE_PATH}/test/output-validation-test/test-output-validation
6767

68-
build-binaries: create-build-dir
68+
build-binaries:
6969
${MAKEFILE_PATH}/scripts/build-binaries -d -p ${SUPPORTED_PLATFORMS} -v ${VERSION}
7070

71-
upload-resources-to-github:
71+
## requires a github token
72+
upload-resources-to-github:
7273
${MAKEFILE_PATH}/scripts/upload-resources-to-github
7374

75+
## requires a dockerhub token
7476
sync-readme-to-dockerhub:
7577
${MAKEFILE_PATH}/scripts/sync-readme-to-dockerhub
7678

77-
unit-test: create-build-dir
79+
unit-test:
7880
go test -bench=. ${MAKEFILE_PATH}/... -v -coverprofile=coverage.out -covermode=atomic -outputdir=${BUILD_DIR_PATH}
7981

80-
build: create-build-dir compile
82+
build: compile
8183

82-
release: create-build-dir build-binaries build-docker-images push-docker-images upload-resources-to-github
84+
release: build-binaries build-docker-images push-docker-images upload-resources-to-github
8385

8486
test: spellcheck unit-test license-test go-report-card-test output-validation-test readme-codeblock-test
8587

0 commit comments

Comments
 (0)