ecs-agent depends on deprecated Docker packages

[SuperQ]

It looks like the ecs-agent package has fallen behind on its depedency with github.com/docker/docker.

The main issue is that with v29 they've finally decided to fully switch to github.com/moby/moby.

The secondary issue is that a few uses have changed upstream so if you update to v28 there are missing types.

# github.com/aws/amazon-ecs-agent/ecs-agent/tmds/handlers/v4/state
../../../go/pkg/mod/github.com/aws/amazon-ecs-agent/ecs-agent@v0.0.0-20260421173302-3def019fc9fa/tmds/handlers/v4/state/response.go:142:9: undefined: types.StatsJSON

[mye956]

Hi @SuperQ thanks for opening raising this issue! There was some progress on our end to try to bump up the docker client version to v28 (although not sure why the PR was closed). We'll look to pick it back up.

[SuperQ]

I made #4957 to fix this.

[SuperQ]

FYI, I noticed that this project is still using the outdated practice of Go inline vendor dirs. These can be removed with Go modules as the go.mod and go.sum track the vendor code.

[mye956]

Thanks, we'll help review.

I noticed that this project is still using the outdated practice of Go inline vendor dirs

Yes that's a fair observation. The rationale for this is we're sharing implementation (e.g. the ecs-agent/ directory) in sources where network may be limited/not public.

[SuperQ]

Typically organizations like that use private module proxies.