Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visual indication that /acceptall is enabled #1042

Closed
mschrage opened this issue Apr 1, 2025 · 4 comments · Fixed by #1120
Closed

Add visual indication that /acceptall is enabled #1042

mschrage opened this issue Apr 1, 2025 · 4 comments · Fixed by #1120
Assignees
@hayemaxi
Labels
good first issue Good for newcomers

Comments

@mschrage
Copy link
Contributor

mschrage commented Apr 1, 2025

Current Behavior

It is not obvious to a user whether /acceptall behavior is enabled by looking at chat interface

Expected Behavior

Add an indication to the prompt that /acceptall is enabled, potentially changing the color or adding a badge to the prompt.

[accept-all] >
@mschrage mschrage added the good first issue Good for newcomers label Apr 1, 2025
@GoodluckH GoodluckH self-assigned this Apr 1, 2025
@hayemaxi
Copy link
Collaborator

hayemaxi commented Apr 3, 2025 •
edited
Loading

Won't apply as worded after #1054.
Maybe [all-tools-trusted]?

@GoodluckH
Copy link
Collaborator

Yes, I can assign this to you then and convert this as a sub-issue

@GoodluckH GoodluckH assigned hayemaxi and unassigned GoodluckH Apr 3, 2025
@GoodluckH GoodluckH linked a pull request Apr 3, 2025 that will close this issue
feat(commands): granular permissions with /tools #1054
Merged
@hayemaxi hayemaxi removed a link to a pull request Apr 3, 2025
feat(commands): granular permissions with /tools #1054
Merged
@hayemaxi hayemaxi linked a pull request Apr 4, 2025 that will close this issue
Granular tool permissions #921
Open
@hayemaxi hayemaxi removed a link to a pull request Apr 4, 2025
Granular tool permissions #921
Open
@hayemaxi
Copy link
Collaborator

hayemaxi commented Apr 4, 2025 •
edited
Loading

BTW the profiles system already adds a tag:

Image

Do we still want this? Looks a little cluttered either way

Image Image

@mschrage
Copy link
Contributor Author

mschrage commented Apr 7, 2025

Hmm, maybe just add red "!" next to the prompt. A but more subtle, but should still communicate this information.

[profile] !>

hayemaxi added a commit to hayemaxi/amazon-q-developer-cli that referenced this issue Apr 7, 2025
@hayemaxi
feat(chat): all-tools-trusted indicator
0576820 
Ref: aws#1042

Attaches a red ! to ">" prompt indicator if **all** available tools are trusted.
hayemaxi added a commit to hayemaxi/amazon-q-developer-cli that referenced this issue Apr 7, 2025
@hayemaxi
feat(chat): all-tools-trusted indicator
fc17650 
Ref: aws#1042

Attaches a red ! to ">" prompt indicator if **all** available tools are trusted.
@hayemaxi hayemaxi mentioned this issue Apr 7, 2025
Merged
@hayemaxi hayemaxi linked a pull request Apr 7, 2025 that will close this issue
feat(chat): all-tools-trusted indicator #1120
Merged
brandonskiser pushed a commit that referenced this issue Apr 9, 2025
@hayemaxi @brandonskiser
feat(chat): all-tools-trusted indicator
8cff119 
Ref: #1042

Attaches a red ! to ">" prompt indicator if **all** available tools are trusted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hayemaxi hayemaxi

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(chat): all-tools-trusted indicator hayemaxi/amazon-q-developer-cli
3 participants
@mschrage @GoodluckH @hayemaxi