Skip to content

Commit be87d47

Browse files
committed
fix(auth, AdfsCredentialsProvider): Fixes a login issue that did not allow the loginToRp connection parameter in the AdfsCredentialsProvider to be set
1 parent 1b4b032 commit be87d47

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

redshift_connector/__init__.py

+2
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ def connect(
135135
partner_sp_id: typing.Optional[str] = None,
136136
idp_response_timeout: typing.Optional[int] = None,
137137
listen_port: typing.Optional[int] = None,
138+
login_to_rp: typing.Optional[str] = None,
138139
login_url: typing.Optional[str] = None,
139140
auto_create: typing.Optional[bool] = None,
140141
db_groups: typing.Optional[typing.List[str]] = None,
@@ -302,6 +303,7 @@ def connect(
302303
info.put("is_serverless", is_serverless)
303304
info.put("listen_port", listen_port)
304305
info.put("login_url", login_url)
306+
info.put("login_to_rp", login_to_rp)
305307
info.put("max_prepared_statements", max_prepared_statements)
306308
info.put("numeric_to_float", numeric_to_float)
307309
info.put("partner_sp_id", partner_sp_id)

test/unit/test_redshift_property.py

+12
Original file line numberDiff line numberDiff line change
@@ -140,3 +140,15 @@ def test_set_is_cname_from_host(conn_params, exp_is_cname) -> None:
140140

141141
info.set_is_cname()
142142
assert info.is_cname == exp_is_cname
143+
144+
145+
def test_login_to_rp_exists() -> None:
146+
info: RedshiftProperty = RedshiftProperty()
147+
148+
assert info.__getattribute__("login_to_rp")
149+
150+
151+
def test_can_set_login_to_rp() -> None:
152+
info: RedshiftProperty = RedshiftProperty(**{"login_to_rp": "foo_bar"})
153+
154+
assert info.__getattribute__("login_to_rp") == "foo_bar"

0 commit comments

Comments
 (0)