Skip to content

Commit 05d6e6d

Browse files
author
Tarun Belani
committed
Addressed review comments
1 parent 17308e0 commit 05d6e6d

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -543,6 +543,11 @@ export class DistributionConfiguration extends DistributionConfigurationBase {
543543
);
544544
}
545545

546+
const { region: _, ...amiDistributionWithoutRegion }: AmiDistribution = amiDistribution;
547+
if (Object.keys(amiDistributionWithoutRegion).length === 0) {
548+
throw new cdk.ValidationError('at least one AMI distribution property must be set', this);
549+
}
550+
546551
this.amiDistributionsByRegion[region] = amiDistribution;
547552
});
548553
}

packages/@aws-cdk/aws-imagebuilder-alpha/test/distribution-configuration.test.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -528,6 +528,14 @@ describe('Distribution Configuration', () => {
528528
}).toThrow(cdk.ValidationError);
529529
});
530530

531+
test('throws a validation error when no properties are defined on an AMI distribution', () => {
532+
const distributionConfiguration = new DistributionConfiguration(stack, 'DistributionConfiguration');
533+
534+
expect(() => {
535+
distributionConfiguration.addAmiDistributions({ region: 'us-east-1' });
536+
}).toThrow(cdk.ValidationError);
537+
});
538+
531539
test('throws a validation error when providing a max parallel launch below 6 for fast launch configurations', () => {
532540
const distributionConfiguration = new DistributionConfiguration(stack, 'DistributionConfiguration');
533541
distributionConfiguration.addAmiDistributions({ fastLaunchConfigurations: [{ maxParallelLaunches: 5 }] });

0 commit comments

Comments
 (0)