feat(s3-deployment): address PR review comments

- Rename feature flag from 'defaultMemoryLimit' to 'default512MemoryLimit' for clarity
- Simplify README documentation to remove feature flag mention since it defaults to true
- Simplify JSDoc comment to show '@default 512' without feature flag details
- Update all references to use the new feature flag name

Author: Jamie Yang

packages/aws-cdk-lib/aws-s3-deployment/README.md

@@ -362,7 +362,7 @@ new s3deploy.BucketDeployment(this, 'DeployWithSignedPayloads', {
 
 ## Size Limits
 
-The default memory limit for the deployment resource is 512MiB when the feature flag `@aws-cdk/aws-s3-deployment:defaultMemoryLimit` is enabled, otherwise 128MiB. If you need to
+The default memory limit for the deployment resource is 512MiB. If you need to
 copy larger files, you can use the `memoryLimit` configuration to increase the
 size of the AWS Lambda resource handler.
 

packages/aws-cdk-lib/aws-s3-deployment/lib/bucket-deployment.ts

@@ -156,7 +156,7 @@ export interface BucketDeploymentProps {
    * If you are deploying large files, you will need to increase this number
    * accordingly.
    *
-   * @default 512 when feature flag `@aws-cdk/aws-s3-deployment:defaultMemoryLimit` is enabled, otherwise 128
+   * @default 512
    */
   readonly memoryLimit?: number;
 
@@ -382,7 +382,7 @@ export class BucketDeployment extends Construct {
       lambdaPurpose: 'Custom::CDKBucketDeployment',
       timeout: cdk.Duration.minutes(15),
       role: props.role,
-      memorySize: props.memoryLimit ?? (FeatureFlags.of(this).isEnabled(cxapi.S3_DEPLOYMENT_DEFAULT_MEMORY_LIMIT) ? 512 : 128),
+      memorySize: props.memoryLimit ?? (FeatureFlags.of(this).isEnabled(cxapi.S3_DEPLOYMENT_DEFAULT_512_MEMORY_LIMIT) ? 512 : 128),
       ephemeralStorageSize: props.ephemeralStorageSize,
       vpc: props.vpc,
       vpcSubnets: props.vpcSubnets,

packages/aws-cdk-lib/aws-s3-deployment/test/bucket-deployment.test.ts

@@ -813,7 +813,7 @@ test('default memory limit is 128MB when feature flag is disabled', () => {
 test('default memory limit is 512MB when feature flag is enabled', () => {
   // GIVEN
   const stack = new cdk.Stack();
-  stack.node.setContext('@aws-cdk/aws-s3-deployment:defaultMemoryLimit', true);
+  stack.node.setContext('@aws-cdk/aws-s3-deployment:default512MemoryLimit', true);
   const bucket = new s3.Bucket(stack, 'Dest');
 
   // WHEN

packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md

@@ -107,7 +107,7 @@ Flags come in three types:
 | [@aws-cdk/core:explicitStackTags](#aws-cdkcoreexplicitstacktags) | When enabled, stack tags need to be assigned explicitly on a Stack. | 2.205.0 | new default |
 | [@aws-cdk/aws-signer:signingProfileNamePassedToCfn](#aws-cdkaws-signersigningprofilenamepassedtocfn) | Pass signingProfileName to CfnSigningProfile | 2.212.0 | fix |
 | [@aws-cdk/aws-ecs-patterns:secGroupsDisablesImplicitOpenListener](#aws-cdkaws-ecs-patternssecgroupsdisablesimplicitopenlistener) | Disable implicit openListener when custom security groups are provided | 2.214.0 | new default |
-| [@aws-cdk/aws-s3-deployment:defaultMemoryLimit](#aws-cdkaws-s3-deploymentdefaultmemorylimit) | Use 512MB memory for BucketDeployment Lambda function instead of 128MB | V2NEXT | new default |
+| [@aws-cdk/aws-s3-deployment:default512MemoryLimit](#aws-cdkaws-s3-deploymentdefault512memorylimit) | Use 512MB memory for BucketDeployment Lambda function instead of 128MB | V2NEXT | new default |
 
 <!-- END table -->
 
@@ -198,7 +198,7 @@ The following json shows the current recommended set of flags, as `cdk init` wou
     "@aws-cdk/s3-notifications:addS3TrustKeyPolicyForSnsSubscriptions": true,
     "@aws-cdk/aws-ec2:requirePrivateSubnetsForEgressOnlyInternetGateway": true,
     "@aws-cdk/aws-s3:publicAccessBlockedByDefault": true,
-    "@aws-cdk/aws-s3-deployment:defaultMemoryLimit": true,
+    "@aws-cdk/aws-s3-deployment:default512MemoryLimit": true,
     "@aws-cdk/aws-lambda:useCdkManagedLogGroup": true
   }
 }
@@ -2279,7 +2279,7 @@ override this behavior.
 **Compatibility with old behavior:** You can pass `openListener: true` explicitly to maintain the old behavior.
 
 
-### @aws-cdk/aws-s3-deployment:defaultMemoryLimit
+### @aws-cdk/aws-s3-deployment:default512MemoryLimit
 
 *Use 512MB memory for BucketDeployment Lambda function instead of 128MB*
 

packages/aws-cdk-lib/cx-api/lib/features.ts

@@ -145,7 +145,7 @@ export const EC2_REQUIRE_PRIVATE_SUBNETS_FOR_EGRESSONLYINTERNETGATEWAY = '@aws-c
 export const USE_RESOURCEID_FOR_VPCV2_MIGRATION = '@aws-cdk/aws-ec2-alpha:useResourceIdForVpcV2Migration';
 export const S3_PUBLIC_ACCESS_BLOCKED_BY_DEFAULT = '@aws-cdk/aws-s3:publicAccessBlockedByDefault';
 export const USE_CDK_MANAGED_LAMBDA_LOGGROUP = '@aws-cdk/aws-lambda:useCdkManagedLogGroup';
-export const S3_DEPLOYMENT_DEFAULT_MEMORY_LIMIT = '@aws-cdk/aws-s3-deployment:defaultMemoryLimit';
+export const S3_DEPLOYMENT_DEFAULT_512_MEMORY_LIMIT = '@aws-cdk/aws-s3-deployment:default512MemoryLimit';
 
 export const FLAGS: Record<string, FlagInfo> = {
   //////////////////////////////////////////////////////////////////////
@@ -1696,7 +1696,7 @@ export const FLAGS: Record<string, FlagInfo> = {
   },
 
   //////////////////////////////////////////////////////////////////////
-  [S3_DEPLOYMENT_DEFAULT_MEMORY_LIMIT]: {
+  [S3_DEPLOYMENT_DEFAULT_512_MEMORY_LIMIT]: {
     type: FlagType.ApiDefault,
     summary: 'Use 512MB memory for BucketDeployment Lambda function instead of 128MB',
     detailsMd: `

packages/aws-cdk-lib/cx-api/test/features.test.ts

@@ -51,7 +51,7 @@ test('feature flag defaults may not be changed anymore', () => {
     [feats.USE_CDK_MANAGED_LAMBDA_LOGGROUP]: false,
     [feats.SIGNER_PROFILE_NAME_PASSED_TO_CFN]: false,
     [feats.ECS_PATTERNS_SEC_GROUPS_DISABLES_IMPLICIT_OPEN_LISTENER]: false,
-    [feats.S3_DEPLOYMENT_DEFAULT_MEMORY_LIMIT]: false,
+    [feats.S3_DEPLOYMENT_DEFAULT_512_MEMORY_LIMIT]: false,
 
   });
 });

packages/aws-cdk-lib/recommended-feature-flags.json

@@ -78,6 +78,6 @@
   "@aws-cdk/s3-notifications:addS3TrustKeyPolicyForSnsSubscriptions": true,
   "@aws-cdk/aws-ec2:requirePrivateSubnetsForEgressOnlyInternetGateway": true,
   "@aws-cdk/aws-s3:publicAccessBlockedByDefault": true,
-  "@aws-cdk/aws-s3-deployment:defaultMemoryLimit": true,
+  "@aws-cdk/aws-s3-deployment:default512MemoryLimit": true,
   "@aws-cdk/aws-lambda:useCdkManagedLogGroup": true
 }