Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: sdk logging present even though verbose logging is not turned on #33320

Closed
1 task
oceanofmaya opened this issue Feb 6, 2025 · 7 comments · Fixed by #33324
Closed
1 task

cli: sdk logging present even though verbose logging is not turned on #33320

oceanofmaya opened this issue Feb 6, 2025 · 7 comments · Fixed by #33324
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort management/tracking Issues that track a subject or multiple issues p0 package/tools Related to AWS CDK Tools or CLI

Comments

@oceanofmaya
Copy link

oceanofmaya commented Feb 6, 2025

Please add your +1 👍 to let us know you have encountered this

Status: IN-PROGRESS

Overview:

In v2.178.0 every CLI command is printing additional debug traces for AWS SDK calls.

Complete Error Message:

Example:
Image

Workaround:

none, update to v2.178.1 (release in progress)

Solution:

update to v2.178.1 (release in progress)

Related Issues:

n/a


Describe the bug

When CDK Watch is used the SDK logger prints verbose logs continuously reducing the utility of CDK watch as it becomes difficult to view the lambda logs as invocations are made. This wasn't happening before. Based on the SDK logger code, it is supposed to print that if debug was true or trace was true or verbose was requested in the cli. In my case they are not set and uses the default. I also tried with debug as false, and trace as false and I was unable to reduce the verbosity.

Refer screenshot for details (The SDK Info log in my case prints continuously for the CloudWatch.FilterLogEvents)

Image

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

2.176.0

Expected Behavior

SDK Info logs is expected if debug, trace or verbose logging was requested.

Current Behavior

SDK Info logs are always present and it doesn't appear to be configurable.

Reproduction Steps

Running cdk watch on a stack

Possible Solution

If debug is false (default), trace is false (default) and verbose was not requested then SDK Logger should not print SDK Info logs in the CLI output.

Additional Information/Context

No response

CDK CLI Version

2.178.0

Framework Version

No response

Node.js Version

20

OS

Windows

Language

TypeScript

Language Version

5.x

Other information

No response

@oceanofmaya oceanofmaya added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 6, 2025
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Feb 6, 2025
@juweeks
Copy link

juweeks commented Feb 6, 2025

getting the [SDK info] tag in the normal cdk diff command

@blimmer
Copy link
Contributor

blimmer commented Feb 6, 2025

I just confirmed that the breaking change occurred in 2.178.0 - 2.177.0 works as expected.

@pahud pahud added p2 effort/medium Medium work item – several days of effort p1 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. p2 labels Feb 6, 2025
@pahud pahud self-assigned this Feb 6, 2025
@oceanofmaya
Copy link
Author

@blimmer I found this change in version 2.178.0 https://github.com/aws/aws-cdk/pull/33234/files which might be the root cause for the change in behavior.

@mrgrain
Copy link
Contributor

mrgrain commented Feb 6, 2025

Looking into it.

@pahud pahud removed their assignment Feb 6, 2025
@pahud pahud removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Feb 6, 2025
@mergify mergify bot closed this as completed in #33324 Feb 6, 2025
@mergify mergify bot closed this as completed in 29a9a6d Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link

github-actions bot commented Feb 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2025
@aws aws unlocked this conversation Feb 6, 2025
@mrgrain
Copy link
Contributor

mrgrain commented Feb 6, 2025

Fix is merged. We are kicking off the release imminently, but it will take a few hours.

@mrgrain mrgrain added p0 and removed p1 labels Feb 6, 2025
@mrgrain mrgrain pinned this issue Feb 6, 2025
@mrgrain mrgrain added the management/tracking Issues that track a subject or multiple issues label Feb 6, 2025
github-merge-queue bot pushed a commit to cdklabs/aws-cdk-notices that referenced this issue Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort management/tracking Issues that track a subject or multiple issues p0 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants