feat(ivs): support Multitrack Video #33370

mazyu36 · 2025-02-11T00:53:33Z

Issue # (if applicable)

N/A

Reason for this change

To support Multitrack video features.

Description of changes

Add following properties:

containerFormat
multitrackInputConfiguration

Describe any new or updated permissions being added

Nothing.

Description of how you validated changes

Add unit tests and an integ test.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

(This review is outdated)

codecov · 2025-02-11T01:06:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (ede5842) to head (02791bb).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33370   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files         238      238           
  Lines       14269    14269           
  Branches     2492     2492           
=======================================
  Hits        11558    11558           
  Misses       2425     2425           
  Partials      286      286

Flag	Coverage Δ
suite.unit	`81.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`79.92% <ø> (ø)`
packages/aws-cdk-lib/core	`82.16% <ø> (ø)`

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

mazyu36 · 2025-02-12T02:56:27Z

packages/@aws-cdk/aws-ivs-alpha/lib/channel.ts

@@ -235,6 +331,15 @@ export class Channel extends ChannelBase {
      type: props.type,
      preset,
      recordingConfigurationArn: props.recordingConfiguration?.recordingConfigurationArn,
+      containerFormat: props.containerFormat ??
+        (props.multitrackInputConfiguration ? ContainerFormat.FRAGMENTED_MP4 : undefined),


When using multitrack video, the containerFormat needs to be set to fMP4.
Therefore, when multitrackInputConfiguration is set but containerFormat is not specified, I configured it to automatically set fMP4.
While I considered making it a validation error when containerFormat is not set, I decided this approach would be more user-friendly.

agree with this approach 👍

mazyu36 · 2025-02-12T12:00:27Z

packages/@aws-cdk/aws-ivs-alpha/lib/channel.ts

+        (props.multitrackInputConfiguration ? ContainerFormat.FRAGMENTED_MP4 : undefined),
+      multitrackInputConfiguration: props.multitrackInputConfiguration ?
+        {
+          enabled: true,


There are two configuration patterns for multitrackInputConfiguration in CFn:

When enabled is false, other properties cannot be set. The IVS default setting has enabled as false.

When enabled is true, other properties must be set.

I felt that implementing these patterns in validation would become complex, and there's no real need to explicitly set enabled to false.
Therefore, in the L2 Construct, I abstracted this so that multitrackInputConfiguration is only set when we want to use multitrack video with enabled set to true.

agree with this

aaythapa

No notes, this LGTM. Thank you for the contribution as always

aaythapa · 2025-02-13T21:52:44Z

packages/@aws-cdk/aws-ivs-alpha/lib/channel.ts

@@ -235,6 +331,15 @@ export class Channel extends ChannelBase {
      type: props.type,
      preset,
      recordingConfigurationArn: props.recordingConfiguration?.recordingConfigurationArn,
+      containerFormat: props.containerFormat ??
+        (props.multitrackInputConfiguration ? ContainerFormat.FRAGMENTED_MP4 : undefined),


agree with this approach 👍

aaythapa · 2025-02-13T21:53:03Z

packages/@aws-cdk/aws-ivs-alpha/lib/channel.ts

+        (props.multitrackInputConfiguration ? ContainerFormat.FRAGMENTED_MP4 : undefined),
+      multitrackInputConfiguration: props.multitrackInputConfiguration ?
+        {
+          enabled: true,


agree with this

mergify · 2025-02-13T22:02:48Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-02-13T22:07:54Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2025-02-13T23:02:10Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 02791bb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-02-13T23:02:26Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-02-13T23:02:44Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

feat(ivs): support Multitrack Video

338bad3

github-actions bot added the p2 label Feb 11, 2025

aws-cdk-automation requested a review from a team February 11, 2025 00:53

github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Feb 11, 2025

aws-cdk-automation previously requested changes Feb 11, 2025

View reviewed changes

mazyu36 added 2 commits February 11, 2025 19:51

add integ

f180842

update

bd045de

improve containerFomat default

12393ae

mazyu36 force-pushed the feature/ivs-multitrack-input branch from fafae4f to 12393ae Compare February 12, 2025 01:15

fix README

bfd490d

mazyu36 marked this pull request as ready for review February 12, 2025 02:50

Merge branch 'main' into feature/ivs-multitrack-input

d6b72a3

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 12, 2025

mazyu36 commented Feb 12, 2025

View reviewed changes

aaythapa approved these changes Feb 13, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 13, 2025

Merge branch 'main' into feature/ivs-multitrack-input

02791bb

mergify bot merged commit 29d1945 into aws:main Feb 13, 2025
20 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2025

mazyu36 deleted the feature/ivs-multitrack-input branch February 13, 2025 23:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ivs): support Multitrack Video #33370

feat(ivs): support Multitrack Video #33370

mazyu36 commented Feb 11, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

codecov bot commented Feb 11, 2025 •

edited

Loading

mazyu36 Feb 12, 2025

aaythapa Feb 13, 2025

mazyu36 Feb 12, 2025

aaythapa Feb 13, 2025

aaythapa left a comment •

edited

Loading

aaythapa Feb 13, 2025

aaythapa Feb 13, 2025

mergify bot commented Feb 13, 2025

mergify bot commented Feb 13, 2025

aws-cdk-automation commented Feb 13, 2025

mergify bot commented Feb 13, 2025

github-actions bot commented Feb 13, 2025

feat(ivs): support Multitrack Video #33370

feat(ivs): support Multitrack Video #33370

Conversation

mazyu36 commented Feb 11, 2025 • edited Loading

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

aws-cdk-automation left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Feb 11, 2025 • edited Loading

Codecov Report

mazyu36 Feb 12, 2025

Choose a reason for hiding this comment

aaythapa Feb 13, 2025

Choose a reason for hiding this comment

mazyu36 Feb 12, 2025

Choose a reason for hiding this comment

aaythapa Feb 13, 2025

Choose a reason for hiding this comment

aaythapa left a comment • edited Loading

Choose a reason for hiding this comment

aaythapa Feb 13, 2025

Choose a reason for hiding this comment

aaythapa Feb 13, 2025

Choose a reason for hiding this comment

mergify bot commented Feb 13, 2025

mergify bot commented Feb 13, 2025

aws-cdk-automation commented Feb 13, 2025

AWS CodeBuild CI Report

mergify bot commented Feb 13, 2025

github-actions bot commented Feb 13, 2025

mazyu36 commented Feb 11, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

codecov bot commented Feb 11, 2025 •

edited

Loading

aaythapa left a comment •

edited

Loading