Skip to content

Commit 16fa35a

Browse files
authored
Drop explicit/pinned libloading dependency (#913)
Unlike clap and criterion, which are pinned dev-dependencies, libloading shows up in downstream dependency graphs. As such, pinning libloading to 0.8.8 in these crates holds back its use in all downstream projects, the vast majority of which will have a newer MSRV. As such, pinning is not a great solution for the problem at hand. Instead, adjust CI workflows to make sure an older libloading is used.
1 parent 4b35869 commit 16fa35a

File tree

4 files changed

+1
-13
lines changed

4 files changed

+1
-13
lines changed

.github/workflows/integration.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,7 @@ jobs:
344344
- name: Update dependencies
345345
run: |
346346
cargo +1.70.0 update
347+
cargo +1.70.0 update -p libloading --precise 0.8.8
347348
cargo +1.70.0 tree
348349
349350
- name: Verify msrv

Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@ untrusted = "0.7.1"
3333
zeroize = "1.8.1"
3434
toml_edit = "0.23.0"
3535

36-
# libloading v0.8.9 has MSRV of 1.71.0
37-
libloading = "=0.8.8"
38-
3936
[profile.bench]
4037
lto = true
4138

aws-lc-fips-sys/Cargo.toml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@ dunce.workspace = true
7070
fs_extra.workspace = true
7171
cc.workspace = true
7272
regex.workspace = true
73-
# libloading v0.8.9 has MSRV of 1.71.0
74-
libloading.workspace = true
7573

7674
[target.'cfg(all(any(target_arch = "x86_64", target_arch = "aarch64"), any(target_os = "linux", target_os = "macos"), any(target_env = "gnu", target_env = "musl", target_env = "")))'.build-dependencies]
7775
bindgen = { workspace = true, optional = true }
@@ -84,6 +82,3 @@ regex.workspace = true
8482

8583
[package.metadata.aws-lc-fips-sys]
8684
commit-hash = "fcd86b8478a66721b3356e1fe85a0d1e31a4e834"
87-
88-
[package.metadata.cargo-udeps.ignore]
89-
build = ["libloading"]

aws-lc-sys/Cargo.toml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,6 @@ cmake.workspace = true
6969
dunce.workspace = true
7070
fs_extra.workspace = true
7171
cc = { workspace = true, features = ["parallel"] }
72-
# libloading v0.8.9 has MSRV of 1.71.0
73-
libloading.workspace = true
7472

7573
[target.'cfg(any(all(any(target_arch="x86_64",target_arch="aarch64"),any(target_os="linux",target_os="macos",target_os="windows"),any(target_env="gnu",target_env="musl",target_env="msvc",target_env="")),all(target_arch="x86",target_os="windows",target_env="msvc"),all(target_arch="x86",target_os="linux",target_env="gnu")))'.build-dependencies]
7674
bindgen = { workspace = true, optional = true }
@@ -80,6 +78,3 @@ bindgen.workspace = true
8078

8179
[package.metadata.aws-lc-sys]
8280
commit-hash = "8ca0b29b141bb8c7eae06ef324e2091d5648d819"
83-
84-
[package.metadata.cargo-udeps.ignore]
85-
build = ["libloading"]

0 commit comments

Comments
 (0)