Add minimal EC CLI tool implementation #2640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2640 +/- ##
==========================================
+ Coverage 78.96% 78.98% +0.01%
==========================================
Files 671 673 +2
Lines 114798 114962 +164
Branches 16153 16164 +11
==========================================
+ Hits 90655 90799 +144
- Misses 23358 23377 +19
- Partials 785 786 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
Oct 1, 2025
smittals2
reviewed
Oct 1, 2025
justsmth
force-pushed
the
implement-ec-cli
branch
from
59b4c0e to
6b751a0
Compare
justsmth
previously approved these changes
Oct 3, 2025
smittals2
previously approved these changes
Oct 6, 2025
justsmth
previously approved these changes
Oct 6, 2025
smittals2
previously approved these changes
Oct 6, 2025
- Create ec.cc with EC-specific key processing - Support options: -inform, -in, -pubout, -out, -outform - Handle PEM/DER format conversion for EC private/public keys - Use EC-specific AWS-LC APIs for proper key handling - Integrate ecTool into build system (CMakeLists.txt, internal.h, tool.cc) - Tested format conversion and OpenSSL interoperability Assisted by Amazon Q
- Create ec_test.cc with cross-compatibility testing - Test all minimal EC options: -inform, -in, -pubout, -out, -outform - Include format conversion tests (PEM/DER) and round-trip validation - Add error handling tests for invalid inputs/outputs - Support conditional OpenSSL cross-compatibility when env vars set - Use BIO pattern consistent with other AWS-LC tool tests - All 13 tests pass including OpenSSL interoperability validation Assisted by Amazon Q
- Load original keys for comparison in both round-trip tests - Use BN_cmp() to validate private key values remain identical - Ensures data integrity through PEM↔DER format conversions
- Use isStringUpperCaseEqual() for case-insensitive format checking - Simplify error messages to show only supported formats - Make format validation consistent with other tools
justsmth
force-pushed
the
implement-ec-cli
branch
from
37222e1 to
cd66ebf
Compare
justsmth
approved these changes
Oct 7, 2025
smittals2
approved these changes
Oct 7, 2025
Merged
justsmth
added a commit
that referenced
this pull request
Oct 13, 2025
### Description of changes: Prepare v1.62.0 release #### What's Changed * nginx now supports AWS-LC by @samuel40791765 in #2714 * Fix tests that assume X25519 will be negotiated by @alexw91 in #2682 * Fixing a bug in ML-DSA poly_uniform function by @dkostic in #2721 * Migrate integration omnibus by @skmcgrail in #2715 * Delete util/bot directory by @justsmth in #2723 * Don't ignore CMAKE_C_FLAGS w/ MSVC by @justsmth in #2722 * Bump urllib3 from 2.2.3 to 2.5.0 in /tests/ci by @dependabot[bot] in #2551 * Type fix in mldsa by @manastasova in #2308 * Centralize password handling tool-openssl by @kingstjo in #2555 * crypto/pem: replace strncmp with CRYPTO_memcmp to fix -Wstring-compare error by @R3hankhan123 in #2724 * Implement dgst CLI command by @nhatnghiho in #2638 * Add ASN.1 decoding for ML-KEM private keys as seeds by @jakemas in #2707 * Implement genrsa command by @kingstjo in #2535 * Move udiv and sencond tweak calculations to when needed by @nebeid in #2726 * Add null check on RSA key checks by @samuel40791765 in #2727 * Implement workaround for FORTIFY_SOURCE warning with jitterentropy by @skmcgrail in #2728 * Implement coverity suggestions by @skmcgrail in #2730 * Add minimal EC CLI tool implementation by @kingstjo in #2640 * Adding pkeyutl tool to the CLI by @smittals2 in #2575 * Add CI dimensions for legacy AVX512 flags by @smittals2 in #2732 * Fix Libwebsockets CI by @smittals2 in #2737 * Add option ENABLE_SOURCE_MODIFICATION by @justsmth in #2739 * Simple script to build/run tests by @justsmth in #2736 * Add build-time option to opt-out of CPU Jitter Entropy by @torben-hansen in #2733 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #CryptoAlg-3382
Description of changes:
This PR implements a minimal EC CLI tool for AWS-LC to provide EC key processing capabilities similar to OpenSSL's
openssl eccommand. The tool supports essential EC key operations including format conversion between PEM/DER for both private and public keys, using AWS-LC's native EC APIs for proper key handling.Testing:
ec_test.cccovering:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.