Add type check for ObjectMetadata arg

Author: davidh44

test/v2-migration-tests/src/test/resources/software/amazon/awssdk/v2migrationtests/maven/after/src/main/java/foo/bar/S3Streaming.java

@@ -65,6 +65,8 @@ void putObject_bucketKeyStreamMetadata(String bucket, String key, InputStream st
         HeadObjectResponse metadataWithoutLength = HeadObjectResponse.builder()
             .build();
         /*AWS SDK for Java v2 migration: When using InputStream to upload with S3Client, Content-Length should be specified and used with RequestBody.fromInputStream(). Otherwise, the entire stream will be buffered in memory. If content length must be unknown, we recommend using the CRT-based S3 client - https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/crt-based-s3-client.html*/s3.putObject(PutObjectRequest.builder().bucket(bucket).key(key).build(), RequestBody.fromContentProvider(() -> stream, "application/octet-stream"));
+
+        /*AWS SDK for Java v2 migration: When using InputStream to upload with S3Client, Content-Length should be specified and used with RequestBody.fromInputStream(). Otherwise, the entire stream will be buffered in memory. If content length must be unknown, we recommend using the CRT-based S3 client - https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/crt-based-s3-client.html*/s3.putObject(PutObjectRequest.builder().bucket("bucket").key("key").build(), RequestBody.fromContentProvider(() -> stream, "application/octet-stream"));
     }
 
     /**

test/v2-migration-tests/src/test/resources/software/amazon/awssdk/v2migrationtests/maven/before/src/main/java/foo/bar/S3Streaming.java

@@ -57,6 +57,8 @@ void putObject_bucketKeyStreamMetadata(String bucket, String key, InputStream st
 
         ObjectMetadata metadataWithoutLength = new ObjectMetadata();
         s3.putObject(bucket, key, stream, metadataWithoutLength);
+
+        s3.putObject("bucket", "key", stream, new ObjectMetadata());
     }
 
     /**

v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3PutObjectRequestToV2.java

@@ -321,11 +321,18 @@ private J.MethodInvocation transformPutObjectWithStreamAndMetadata(J.MethodInvoc
             addS3Import("PutObjectRequest");
 
             Expression metadata = method.getArguments().get(3);
-            String metadataName = ((J.Identifier) metadata).getSimpleName();
+            String metadataName = null;
+            if (metadata instanceof J.Identifier) {
+                metadataName = ((J.Identifier) metadata).getSimpleName();
+            }
 
             StringBuilder sb = new StringBuilder("PutObjectRequest.builder().bucket(#{any()}).key(#{any()})");
-            addMetadataFields(sb, metadataName, metadataMap);
-            Expression contentLen = retrieveContentLengthForMetadataIfSet(metadataName);
+
+            Expression contentLen = null;
+            if (metadataName != null) {
+                addMetadataFields(sb, metadataName, metadataMap);
+                contentLen = retrieveContentLengthForMetadataIfSet(metadataName);
+            }
 
             Expression[] params = {method.getArguments().get(0), method.getArguments().get(1),
                                    method.getArguments().get(2)};