Skip to content

Commit 57a6845

Browse files
authored
Remove unncessary dependency and ignoredUnusedDeclaredDependency (#6596)
* Remove unncessary dependencies * Address more TODOs
1 parent 9f2e918 commit 57a6845

File tree

4 files changed

+1
-33
lines changed

4 files changed

+1
-33
lines changed

pom.xml

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -542,17 +542,8 @@
542542
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:aws-sdk-java</ignoredUnusedDeclaredDependency>
543543
<!-- Declared by the codegen maven plugins (lite and normal). Not used directly but used to override a transitive dependecy -->
544544
<ignoredUnusedDeclaredDependency>org.codehaus.plexus:plexus-utils</ignoredUnusedDeclaredDependency>
545-
546-
<!-- TODO(post-sra-identity-auth): Once everything is switched to useSraAuth=true, remove this-->
547-
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:http-auth</ignoredUnusedDeclaredDependency>
548-
549-
<!-- TODO(post-sra-identity-auth): With move to SRA Identity & Auth, most clients won't need a
550-
dependency on auth module. But cannot remove it from services/pom.xml until all services
551-
have switched. Some service modules may still need it, because they have tests that use the
552-
old interfaces, but that should become a test scoped dependency in modules where needed.
553-
And the line below removed. -->
554545
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:auth</ignoredUnusedDeclaredDependency>
555-
546+
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:http-auth</ignoredUnusedDeclaredDependency>
556547
<!-- Ignoring any unused declared dependency warnings for access grants plugin across the bundle -->
557548
<ignoredUnusedDeclaredDependency>software.amazon.s3.accessgrants:*</ignoredUnusedDeclaredDependency>
558549
</ignoredUnusedDeclaredDependencies>
@@ -687,13 +678,8 @@
687678
</includeModules>
688679
<excludes>
689680
<exclude>*.internal.*</exclude>
690-
<!-- TODO remove after release -->
691-
<exclude>software.amazon.awssdk.annotations.ReviewBeforeRelease</exclude>
692681
<exclude>software.amazon.awssdk.thirdparty.*</exclude>
693682
<exclude>software.amazon.awssdk.regions.*</exclude>
694-
<exclude>software.amazon.awssdk.regions.*</exclude>
695-
<exclude>software.amazon.awssdk.enhanced.dynamodb.mapper.annotations.DynamoDbSecondaryPartitionKey</exclude>
696-
<exclude>software.amazon.awssdk.enhanced.dynamodb.mapper.annotations.DynamoDbSecondarySortKey</exclude>
697683
</excludes>
698684

699685
<ignoreMissingOldVersion>true</ignoreMissingOldVersion>

services/eventbridge/pom.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,6 @@
6767
<version>${awsjavasdk.version}</version>
6868
</dependency>
6969
<!-- Test Dependencies -->
70-
<!-- TODO(post-sra-identity-auth): auth-crt dependency can be removed as part of
71-
cleanup after all services are on SRA -->
72-
<dependency>
73-
<groupId>software.amazon.awssdk</groupId>
74-
<artifactId>auth-crt</artifactId>
75-
<version>${awsjavasdk.version}</version>
76-
<scope>test</scope>
77-
</dependency>
7870
<dependency>
7971
<groupId>software.amazon.awssdk</groupId>
8072
<artifactId>route53</artifactId>

services/transcribestreaming/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,6 @@
5252
code that explicitly uses it -->
5353
<ignoredUnusedDeclaredDependencies>
5454
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:http-auth-aws-eventstream</ignoredUnusedDeclaredDependency>
55-
56-
<!-- TODO(post-sra-identity-auth): Once this module is switched to useSraAuth=true, remove this-->
57-
<!-- This ignore is already present in the root pom.xml, but seems like the
58-
ignoredUnusedDeclaredDependencies aren't merged. So repeating it here. -->
59-
<ignoredUnusedDeclaredDependency>software.amazon.awssdk:http-auth</ignoredUnusedDeclaredDependency>
6055
</ignoredUnusedDeclaredDependencies>
6156
</configuration>
6257
</plugin>

test/old-client-version-compatibility-test/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,6 @@
6868
<artifactId>auth</artifactId>
6969
<version>${awsjavasdk.version}</version>
7070
</dependency>
71-
<dependency>
72-
<groupId>software.amazon.awssdk</groupId>
73-
<artifactId>http-auth</artifactId>
74-
<version>${awsjavasdk.version}</version>
75-
</dependency>
7671
<dependency>
7772
<groupId>software.amazon.awssdk</groupId>
7873
<artifactId>http-client-spi</artifactId>

0 commit comments

Comments
 (0)