Skip to content

Commit d3808cd

Browse files
committed
chore(signature-v4-multi-region): de-async getSigV4a owing to containers
1 parent 9cd37b2 commit d3808cd

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

packages/signature-v4-multi-region/src/SignatureV4MultiRegion.ts

+5-7
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import {
99
RequestSigningArguments,
1010
} from "@smithy/types";
1111

12-
import { OptionalSigV4aSigner, signatureV4aContainer } from "./signature-v4a-container";
1312
import { OptionalCrtSignerV4, signatureV4CrtContainer } from "./signature-v4-crt-container";
13+
import { OptionalSigV4aSigner, signatureV4aContainer } from "./signature-v4a-container";
1414

1515
/**
1616
* @internal
@@ -39,8 +39,7 @@ export class SignatureV4MultiRegion implements RequestPresigner, RequestSigner {
3939

4040
public async sign(requestToSign: HttpRequest, options: RequestSigningArguments = {}): Promise<HttpRequest> {
4141
if (options.signingRegion === "*") {
42-
const signer = await this.getSigv4aSigner();
43-
return signer.sign(requestToSign, options);
42+
return this.getSigv4aSigner().sign(requestToSign, options);
4443
}
4544
return this.sigv4Signer.sign(requestToSign, options);
4645
}
@@ -55,15 +54,14 @@ export class SignatureV4MultiRegion implements RequestPresigner, RequestSigner {
5554
): Promise<HttpRequest> {
5655
if (options.signingRegion === "*") {
5756
const signer = await this.getSigv4aSigner();
58-
return signer.signWithCredentials(requestToSign, credentials, options);
57+
return this.getSigv4aSigner().signWithCredentials(requestToSign, credentials, options);
5958
}
6059
return this.sigv4Signer.signWithCredentials(requestToSign, credentials, options);
6160
}
6261

6362
public async presign(originalRequest: HttpRequest, options: RequestPresigningArguments = {}): Promise<HttpRequest> {
6463
if (options.signingRegion === "*") {
65-
const signer = await this.getSigv4aSigner();
66-
return signer.presign(originalRequest, options);
64+
return this.getSigv4aSigner().presign(originalRequest, options);
6765
}
6866
return this.sigv4Signer.presign(originalRequest, options);
6967
}
@@ -79,7 +77,7 @@ export class SignatureV4MultiRegion implements RequestPresigner, RequestSigner {
7977
return this.sigv4Signer.presignWithCredentials(originalRequest, credentials, options);
8078
}
8179

82-
private async getSigv4aSigner(): Promise<InstanceType<OptionalCrtSignerV4> | InstanceType<OptionalSigV4aSigner>> {
80+
private getSigv4aSigner(): InstanceType<OptionalCrtSignerV4> | InstanceType<OptionalSigV4aSigner> {
8381
if (!this.sigv4aSigner) {
8482
if (signatureV4CrtContainer.CrtSignerV4) {
8583
// CRT implementation

0 commit comments

Comments
 (0)