Merge pull request #601 from aws/fix

fix: remove unnecessary param

Author: yueny2020

src/lib/ecrUtils.ts

@@ -27,9 +27,8 @@ export async function loginToRegistry(
         tl.setSecret(tokens[1]) // password
     }
 
-    await dockerHandler.runDockerCommand(dockerPath, 'login', ['-u', tokens[0], '--password-stdin', endpoint], {
-        silent: true,
-        input: tokens[1] // Password provided via stdin
+    await dockerHandler.runDockerCommand(dockerPath, 'login', ['-u', tokens[0], '-p', tokens[1], endpoint], {
+        silent: true
     })
 }
 

tests/taskTests/ecrPullImage/ecrPullImage-test.ts

@@ -96,7 +96,7 @@ describe('ECR Pull image', () => {
     })
 
     test('Happy path', async () => {
-        expect.assertions(3)
+        expect.assertions(2)
         const dockerHandler = { ...defaultDocker }
         const runDockerCommand = jest.fn((thing1, thing2, thing3) => Promise.resolve())
         dockerHandler.runDockerCommand = runDockerCommand
@@ -108,7 +108,6 @@ describe('ECR Pull image', () => {
         const taskOperations = new TaskOperations(ecr, dockerHandler, taskParameters)
         await taskOperations.execute()
         expect(ecr.getAuthorizationToken).toBeCalledTimes(1)
-        expect(runDockerCommand.mock.calls[0][2][2]).toStrictEqual('--password-stdin')
-        expect(runDockerCommand.mock.calls[0][2][3]).toStrictEqual('https://example.com')
+        expect(runDockerCommand.mock.calls[0][2][4]).toStrictEqual('https://example.com')
     })
 })