fix filename enoent error, handle readstream errors, and improve log readability (#541)

Author: Rishi Barad

src/lib/beanstalkUtils.ts

@@ -126,18 +126,27 @@ export class BeanstalkUtils {
         objectKey: string
     ): Promise<void> {
         console.log(tl.loc('UploadingBundle', applicationBundlePath, objectKey, bucketName))
-        const fileBuffer = fs.createReadStream(applicationBundlePath)
+
+        // todo: remove duplicated S3 Upload logic across tasks
         try {
-            const response: S3.ManagedUpload.SendData = await s3Client
+            const readStream = fs.createReadStream(applicationBundlePath)
+
+            readStream.on('error', err => {
+                if (err) {
+                    throw err
+                }
+            })
+
+            await s3Client
                 .upload({
                     Bucket: bucketName,
                     Key: objectKey,
-                    Body: fileBuffer
+                    Body: readStream
                 })
                 .promise()
             console.log(tl.loc('BundleUploadCompleted'))
         } catch (err) {
-            console.error(tl.loc('BundleUploadFailed', (err as Error).message), err)
+            console.error(tl.loc('BundleUploadFailed', err))
             throw err
         }
     }

tests/taskTests/common/beanstalkutils-test.ts

@@ -118,10 +118,10 @@ describe('BeanstalkUtils', () => {
         expect.assertions(1)
         const s3 = new S3() as any
         s3.upload = jest.fn(() => {
-            throw Error('it failed')
+            throw Error('Intentional beanstalkutils-test Error')
         })
-        await BeanstalkUtils.uploadBundle(s3, 'path', 'name', 'object').catch(err => {
-            expect(`${err}`).toContain('it failed')
+        await BeanstalkUtils.uploadBundle(s3, __filename, 'name', 'object').catch(err => {
+            expect(`${err}`).toContain('Intentional beanstalkutils-test Error')
         })
     })
 
@@ -131,11 +131,11 @@ describe('BeanstalkUtils', () => {
         s3.upload = jest.fn(args => {
             expect(args.Bucket).toEqual('name')
             expect(args.Key).toEqual('object')
-            expect(args.Body.path).toEqual(path.join(__dirname, __filename))
+            expect(args.Body.path).toEqual(__filename)
 
             return s3BucketResponse
         })
-        await BeanstalkUtils.uploadBundle(s3, path.join(__dirname, __filename), 'name', 'object')
+        await BeanstalkUtils.uploadBundle(s3, __filename, 'name', 'object')
     })
 
     test('VerifyApplicationExists throws on failure', async () => {