Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start url validator es not validating custom sso urls #6341

Closed
marianoVWGroup opened this issue Jan 11, 2025 · 2 comments
Closed

Start url validator es not validating custom sso urls #6341

marianoVWGroup opened this issue Jan 11, 2025 · 2 comments
Labels
auth-credentials authentication, authorization, credentials, AWS Builder ID, sso bug We can reproduce the issue and confirmed it is a bug. pending-release

Comments

@marianoVWGroup
Copy link

marianoVWGroup commented Jan 11, 2025

Problem

Start URL validation is wrong, our sso starting url has a different shape than https://d-xxxxxxxxxx.awsapps.com/start our sso endpoint has other qualifiers and the regex is reporting

"URLs must start with http:// or https://. Example: https://d-xxxxxxxxxx.awsapps.com/start"

this is a bug because our sso works fine but is not ending with ".awsapps.com/start", the end of the url should not be filtered by the regex validaton

Steps to reproduce the issue

put something different than https://d-xxxxxxxxxx.awsapps.com/start

ie:

http://myysso.myowndomain.com/othersubdomain?myqualifiers=true

image

Expected behavior

System details (run AWS: About and/or Amazon Q: About)

  • OS:
  • Visual Studio Code version:
  • AWS Toolkit version:
  • Amazon Q version:
@marianoVWGroup marianoVWGroup added the bug We can reproduce the issue and confirmed it is a bug. label Jan 11, 2025
@justinmk3 justinmk3 added the auth-credentials authentication, authorization, credentials, AWS Builder ID, sso label Jan 13, 2025
@justinmk3
Copy link
Contributor

Thank you for mentioning this! The docs at https://docs.aws.amazon.com/singlesignon/latest/userguide/howtochangeURL.html imply that this wasn't possible, so that's why we used this logic.

We will plan to relax the client-side validation.

@jpinkney-aws
Copy link
Contributor

jpinkney-aws commented Jan 16, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth-credentials authentication, authorization, credentials, AWS Builder ID, sso bug We can reproduce the issue and confirmed it is a bug. pending-release
Projects
None yet
Development

No branches or pull requests

3 participants