Slow to synthesize CloudFrontToS3 pattern with other patterns

[beomseoklee]

I'm using several patterns, and one of them, CloudFrontToS3 pattern is really slow to create a CloudFormation template when I run cdk synth. I put the simple console.time and console.timeEnd to see how long it takes, and I found the below one caused the most time:

aws-solutions-constructs/source/patterns/@aws-solutions-constructs/core/lib/utils.ts

Lines 63 to 68 in 233d3ff

	export function overrideProps(DefaultProps: object, userProps: object, concatArray: boolean = false): any {
	// Notify the user via console output if defaults are overridden
	const overrideWarningsEnabled = (process.env.overrideWarningsEnabled !== 'false');
	if (overrideWarningsEnabled) {
	flagOverriddenDefaults(DefaultProps, userProps);
	}

Reproduction Steps

The below one is the source code from my project (part of the source code):

    console.time('CloudFrontToS3')
    const cloudFrontToS3 = new CloudFrontToS3(this, 'CloudFrontToS3', {
      bucketProps: {
        serverAccessLogsBucket: props.s3LoggingBucket,
        serverAccessLogsPrefix: 's3/'
      },
      cloudFrontDistributionProps: {
        enableLogging: true,
        logBucket: props.s3LoggingBucket,
        logFilePrefix: 'cf/'
      },
      insertHttpSecurityHeaders: false
    });
    console.time('CloudFrontToS3')

Environment

• CDK CLI Version : 1.107.0
• CDK Framework Version: 1.107.0
• AWS Solutions Constructs Version : 1.107.0
• OS : macOS Catalina Version 10.15.7
• Language : TypeScript

Other

This is the time that I measured for different patterns used at the same time:

overrideProps: 0.107ms
KinesisStreamsToKinesisFirehoseToS3: 24.668ms
overrideProps: 0.149ms
overrideProps: 0.084ms
SqsToLambda: 16.71ms
overrideProps: 0.358ms
LambdaToDynamoDB: 8.115ms
overrideProps: 0.139ms
overrideProps: 0.293ms
LambdaToDynamoDB: 4.523ms
overrideProps: 0.089ms
**overrideProps: 6:34.080 (m:ss.mmm)**
(node:36831) Warning: Label 'deepdiff' already exists for console.time()
(node:36831) Warning: Label 'deepdiff' already exists for console.time()
(node:36831) Warning: Label 'deepdiff' already exists for console.time()
(node:36831) Warning: Label 'deepdiff' already exists for console.time()
(node:36831) Warning: Label 'deepdiff' already exists for console.time()
(node:36831) Warning: Label 'CloudFrontToS3' already exists for console.time()

And I don't know what caused the above warning (haven't investigated deeply), but it seems like somewhere, it's looping for the below source code because I only put the time measurement for CloudFrontToS3 once.

aws-solutions-constructs/source/patterns/@aws-solutions-constructs/core/lib/override-warning-service.ts

Lines 61 to 62 in 233d3ff

	function findOverrides(defaultProps: object, userProps: object) {
	const diff = deepdiff.diff(defaultProps, userProps, _prefilter);

If you need more information, please let me know.

---

This is 🐛 Bug Report

[biffgaut]

As we discussed privately, I ran this code and did not see the behavior you report and you were going to look deeper to see how to reproduce this. In the meantime I'll put it on our backlog.

[thebergamo]

I step into this issue while writing my tests using it. It seems that when you provides existingBucket or bucketProps it goes slow and no combination can help with that.

If there is any direction pointed here I would love to contribute with some fix for it.