Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Change structure to support Apple Store #693

Open
digiserg opened this issue Jan 8, 2025 · 4 comments
Open

[feat]: Change structure to support Apple Store #693

digiserg opened this issue Jan 8, 2025 · 4 comments
Assignees
Labels
build enhancement New feature or request in progress the main being handled issue Mac Mac major issue Major issue, lots of change and testing

Comments

@digiserg
Copy link
Collaborator

digiserg commented Jan 8, 2025

I'm trying to submit the Workbench app to the Apple Store but I have encountered a problem with the file structure and third party binaries.

In essence, App Store apps must be self-contained. That is, all the code in the app must be included in the package you submit to the store.

@digiserg digiserg added enhancement New feature or request Needs Triage bugs which are not yet confirmed labels Jan 8, 2025
@digiserg
Copy link
Collaborator Author

digiserg commented Jan 8, 2025

syspolicy.txt

@digiserg digiserg assigned digiserg and unassigned millerjp Jan 8, 2025
@digiserg digiserg added Mac Mac build in progress the main being handled issue major issue Major issue, lots of change and testing and removed Needs Triage bugs which are not yet confirmed labels Jan 8, 2025
@digiserg
Copy link
Collaborator Author

digiserg commented Jan 8, 2025

it looks like we can't use asarUnpack either as this leads to multiple files instead of a single binary

@millerjp
Copy link
Contributor

@mhmdkrmabd you mentioned there was another build format that might resolve this. Could you add the info here?

@mhmdkrmabd
Copy link
Collaborator

Thanks @millerjp

So based on the feedback from @digiserg, the issue might be due to the bundling process of the app's code in an asar file, therefore, we might not do that only for macOS.

Doing this shouldn't lead to apply any changes in the code as we're not relying, in any part of the code, on having it - the source code - bundled. What we might just need is updating the electron-builder command for macOS by passing a --config argument with a config file for macOS, inside that file, we can set asar to be false, and this should be enough.

"mac:mas": "electron-builder --mac dmg zip pkg --publish never --config='custom-config.json'"

{
...
  "copyright": "©2025 AxonOps Limited",
  "appId": "com.axonops.workbench.cassandra",
  "compression": "maximum",
  "asar": false,
  "extraResources": [
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request in progress the main being handled issue Mac Mac major issue Major issue, lots of change and testing
Projects
None yet
Development

No branches or pull requests

3 participants