refactor(WG): remove unused PrepareFakeTeamForBF/ApplyFakeVisualsForBF

Both functions were declared, defined, and never called. They implemented
a "set faction first, apply visuals later" two-step flow for WG war entry,
but the active code path (OnBattlefieldPlayerJoinWar) uses the single-shot
SetFakeRaceAndMorphForBF instead. Removing the dead pair shrinks the
public surface of CFBG and clarifies which methods drive the WG lifecycle.

No behavior change.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Nyeriah

src/CFBG.cpp

@@ -553,60 +553,6 @@ void CFBG::SetFakeRaceAndMorphForBF(Player* player, TeamId assignedTeam)
     _fakePlayerStore.emplace(player, std::move(fakePlayerInfo));
 }
 
-void CFBG::PrepareFakeTeamForBF(Player* player, TeamId assignedTeam)
-{
-    if (!player || IsPlayerFake(player))
-        return;
-
-    TeamId realTeam = player->GetTeamId(true);
-    if (realTeam == assignedTeam)
-        return;
-
-    // Generate race/morph so the full FakePlayer record is ready for when
-    // ApplyFakeVisualsForBF fires later (on war accept).  We do NOT call
-    // setRace / SetDisplayId / SetNativeDisplayId here — only the faction
-    // (team) is changed so that every subsequent core bucket write uses the
-    // assigned team.
-    RandomSkinInfo skinInfo{ GetRandomRaceMorph(realTeam, player->getClass(), player->getGender()) };
-
-    uint8 selectedRace = player->GetPlayerSetting("mod-cfbg", SETTING_CFBG_RACE).value;
-
-    if (!RandomizeRaces() && selectedRace && IsRaceValidForFaction(realTeam, selectedRace))
-    {
-        skinInfo.first = selectedRace;
-        skinInfo.second = GetMorphFromRace(skinInfo.first, player->getGender());
-    }
-
-    FakePlayer fakePlayerInfo
-    {
-        skinInfo.first,
-        skinInfo.second,
-        assignedTeam,
-        player->getRace(true),
-        player->GetDisplayId(),
-        player->GetNativeDisplayId(),
-        realTeam
-    };
-
-    // Team change only — visuals are deferred to ApplyFakeVisualsForBF.
-    SetFactionForRace(player, fakePlayerInfo.FakeRace, fakePlayerInfo.FakeTeamID);
-
-    _fakePlayerStore.emplace(player, std::move(fakePlayerInfo));
-}
-
-void CFBG::ApplyFakeVisualsForBF(Player* player)
-{
-    FakePlayer const* fakeInfo = GetFakePlayer(player);
-    if (!fakeInfo)
-        return;
-
-    // Visual changes deferred from PrepareFakeTeamForBF: apply them now that
-    // the player has actually accepted the war invitation.
-    player->setRace(fakeInfo->FakeRace);
-    player->SetDisplayId(fakeInfo->FakeMorph);
-    player->SetNativeDisplayId(fakeInfo->FakeMorph);
-}
-
 void CFBG::SetFactionForRace(Player* player, uint8 Race, TeamId teamId)
 {
     if (!player)

src/CFBG.h

@@ -164,8 +164,6 @@ class CFBG
     void ValidatePlayerForBG(Battleground* bg, Player* player);
     void SetFakeRaceAndMorph(Player* player);
     void SetFakeRaceAndMorphForBF(Player* player, TeamId assignedTeam);
-    void PrepareFakeTeamForBF(Player* player, TeamId assignedTeam);
-    void ApplyFakeVisualsForBF(Player* player);
     void SetFactionForRace(Player* player, uint8 Race, TeamId teamId);
     void ClearFakePlayer(Player* player);
     void DoForgetPlayersInList(Player* player);