Skip to content

Commit 561fc80

Browse files
committed
fix: return empty list
1 parent 7bb76dd commit 561fc80

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

server.go

+5-1
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,8 @@ func (server *dbServer) handleQueryTableOrView(
143143
}
144144
defer rows.Close()
145145

146-
var rv []map[string]interface{}
146+
// make sure return list instead of null for empty list
147+
rv := make([]map[string]interface{}, 0)
147148
for rows.Next() {
148149
p := make(map[string]interface{})
149150
if err := rows.MapScan(p); err != nil {
@@ -336,6 +337,7 @@ func createServeCmd() *cobra.Command {
336337
setupLogger.Error(err, "failed to open db")
337338
return err
338339
}
340+
defer db.Close()
339341

340342
opts := &ServerOptions{
341343
Logger: logger,
@@ -345,11 +347,13 @@ func createServeCmd() *cobra.Command {
345347

346348
server, err := NewServer(opts)
347349
if err != nil {
350+
setupLogger.Error(err, "failed to create server")
348351
return err
349352
}
350353

351354
ctx, cancel := context.WithCancel(context.Background())
352355
defer cancel()
356+
353357
server.Start(ctx.Done())
354358

355359
return nil

0 commit comments

Comments
 (0)