-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Tweak Vite #150
Comments
So we have
Inside private sign = async (psbtHex: string): Promise<Psbt> => {
if (!psbtHex) throw new Error("psbt hex is required");
const ur = this.dataSdk.btc.generatePSBT(Buffer.from(psbtHex, "hex"));
...
} If I open up 2 versions of Keystone playground - one Storybook story on For some reason:
It will result in Even though both Current solution - we exclude this keystone library from
Whereas if
This is most likely to internal keystone dependencies inside Here is the bump PR that solves the Keystone problem, after it is been built by |
One of the issues we currently have is if we do
Then Keystone will generate not proper QR code. Even though both
simple-staking
andbbn-wallet-connect
will have the same dependency version. If this is called:const ur = this.dataSdk.btc.generatePSBT(Buffer.from(psbtHex, "hex"));
given the same input and same resulting buffer, the length ofthis.dataSdk.btc.generatePSBT
will be different onbbn-wallet-connect
storybook story andsimple-staking
(same psbt hex)If we don't include it there, then
@keystonehq/keystone-sdk
becomes a part of a bundle and increasesbbn-wallet-connect
size from800 Kb
to3.5+ MB
WIP PR that included this SDK in the bundle #151
The text was updated successfully, but these errors were encountered: