fix(sonarqube): sorting fails on missing data in SonarQubeRelatedEntitiesOverview #5297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
vinzscam
approved these changes
Sep 17, 2025
Comment on lines
18
to
30
| describe('datetimeSort', () => { | ||
| [ | ||
| { a: new Date(2025, 1).toISOString(), b: new Date(2026, 2).toISOString() }, | ||
| { a: new Date(2019, 3).toISOString(), b: new Date(2024, 5).toISOString() }, | ||
| { | ||
| a: new Date(2019, 2, 1).toISOString(), | ||
| b: new Date(2019, 2, 2).toISOString(), | ||
| }, | ||
| ].forEach(({ a, b }) => { | ||
| it(`should return negative number when ${a} < ${b}`, () => { | ||
| const result = datetimeSort<string>(x => x)(a, b, undefined); | ||
| expect(result).toBeLessThan(0); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
jest can help a bit here:
Suggested change
| describe('datetimeSort', () => { | |
| [ | |
| { a: new Date(2025, 1).toISOString(), b: new Date(2026, 2).toISOString() }, | |
| { a: new Date(2019, 3).toISOString(), b: new Date(2024, 5).toISOString() }, | |
| { | |
| a: new Date(2019, 2, 1).toISOString(), | |
| b: new Date(2019, 2, 2).toISOString(), | |
| }, | |
| ].forEach(({ a, b }) => { | |
| it(`should return negative number when ${a} < ${b}`, () => { | |
| const result = datetimeSort<string>(x => x)(a, b, undefined); | |
| expect(result).toBeLessThan(0); | |
| }); | |
| }); | |
| describe('datetimeSort', () => { | |
| it.each([ | |
| [new Date(2025, 1), new Date(2026, 2)], | |
| [new Date(2019, 3), new Date(2024, 5)], | |
| [new Date(2019, 2, 1), new Date(2019, 2, 2)], | |
| ])(`should return negative number when %o < %o`, (a, b) => { | |
| const result = datetimeSort<string>(x => x)( | |
| a.toISOString(), | |
| b.toISOString(), | |
| undefined, | |
| ); | |
| expect(result).toBeLessThan(0); | |
| }); |
same below 👇
There was a problem hiding this comment.
Nice, thank you. I have applied your suggestion. Additionally i have wrapped the invalid params in a nested describe.
…itiesOverview` if there are rows without an annotation, meaning no data, then the sorting does not work as intended. The sort-behavior mimics `Array.prototype.sort()`, with undefined values sorted to the end. Signed-off-by: Tom Schneider <[email protected]>
vinzscam
approved these changes
Sep 22, 2025
sebaparedero14
pushed a commit
to sebaparedero14/community-plugins
that referenced
this pull request
Oct 2, 2025
…itiesOverview` (backstage#5297) if there are rows without an annotation, meaning no data, then the sorting does not work as intended. The sort-behavior mimics `Array.prototype.sort()`, with undefined values sorted to the end. Signed-off-by: Tom Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Background: The SonarQubeRelatedEntitiesOverview collects all components of a system and displays them in a table. Those components may or may not have a sonarqube-annotation. The sonarqube-annotation is used to query the API. If there is no annotation, no data is displayed.
Problem: If there are rows without an annotation, meaning no data, then the sorting does not work as intended.
Current faulty behaviour:
Note about the fix:
I did not dig deep enough, but i suspect that the deeply-nested object structure of the resolved object (with potentially undefined values) causes the problem. I opted to add the two sort-function. I am happy for alternative suggestions.
✔️ Checklist
Signed-off-byline in the message. (more info)