Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This will hurt on compound primary keys. #35

Open
todo bot opened this issue Feb 11, 2020 · 0 comments
Open

This will hurt on compound primary keys. #35

todo bot opened this issue Feb 11, 2020 · 0 comments

Comments

@todo
Copy link

todo bot commented Feb 11, 2020

// @TODO This will hurt on compound primary keys.
$primaryKey = $metaData->getPrimaryKeyAttributes($modelObject)[0];
// We need the table to exist in the query in order for the related sort to work.
// Therefore we add it to comply with this by comparing the primary key to not being NULL.
$this->relationSearchFields[$modelName][] = [
$primaryKey, ':', '$$',


This issue was generated by todo based on a TODO comment in 156b946 when #34 was merged. cc @bakaphp.
@todo todo bot added the todo 🗒️ label Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants