From a246a10b298c61c37b38353e29674c5536654184 Mon Sep 17 00:00:00 2001 From: david Date: Wed, 18 Apr 2018 14:38:25 -0600 Subject: [PATCH 1/2] We are working on building a CRUD model generator for SAILSJS and the model schema validations are throwing things off. In our opinion, any model property validation prevents extending the system with dynamic capabilities. There may be a security reason for validating model properties, but if there's not, we recommend removing the model property validation all together (line 237-241 in /lib/waterline-schema/schema.js). Another option is to allow us to register our own model property types that the validator can validate against. Thank you for considering our ideas as a feature request and a way to make great software, quickly. -- David --- accessible/valid-attribute-properties.js | 1 + 1 file changed, 1 insertion(+) diff --git a/accessible/valid-attribute-properties.js b/accessible/valid-attribute-properties.js index d114f86..88f4f0e 100644 --- a/accessible/valid-attribute-properties.js +++ b/accessible/valid-attribute-properties.js @@ -47,4 +47,5 @@ module.exports = [ 'moreInfoUrl', 'example', 'protect', + 'label', ]; From e0ee381aa6e944a1fb09838de994ed5ac4e57536 Mon Sep 17 00:00:00 2001 From: david Date: Wed, 18 Apr 2018 14:38:33 -0600 Subject: [PATCH 2/2] We are working on building a CRUD model generator for SAILSJS and the model schema validations are throwing things off. In our opinion, any model property validation prevents extending the system with dynamic capabilities. There may be a security reason for validating model properties, but if there's not, we recommend removing the model property validation all together (line 237-241 in /lib/waterline-schema/schema.js). Another option is to allow us to register our own model property types that the validator can validate against. Thank you for considering our ideas as a feature request and a way to make great software, quickly. -- David --- accessible/valid-attribute-properties.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/accessible/valid-attribute-properties.js b/accessible/valid-attribute-properties.js index 88f4f0e..d789912 100644 --- a/accessible/valid-attribute-properties.js +++ b/accessible/valid-attribute-properties.js @@ -47,5 +47,14 @@ module.exports = [ 'moreInfoUrl', 'example', 'protect', + + // Request for Helm generator capabilities, for great, quick prototypes. See commit log for explanation 'label', + 'hideFromTable', + 'hideFromForm', + 'notEditable', + 'toolTip', + 'filterable', + 'beforeFormRender', // fn + 'beforeIndexRender', // fn ];