Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow avoid-banned-imports rule to ignore imports with specific show configuration #119

Open
danielgomezrico opened this issue Jan 19, 2024 · 2 comments
Labels
Improvement New feature or request Review/Pending Initial stage of the issue to evaluate its approval

Comments

@danielgomezrico
Copy link

Description
Hi

I am unable to set up the avoid-banned-imports to warn when there's an import from flutter that has a show on my presentation layer, let's say a ViewModel.

I want to allow only the tag visibleForTesting like:

import 'package:flutter/foundation.dart' show visibleForTesting;

And warn if the show is not added, like:

import 'package:flutter/foundation.dart';

Why do you consider it necessary?
This is useful for testing and the tag comes from the flutter SDK 🤔

@danielgomezrico danielgomezrico added the Improvement New feature or request label Jan 19, 2024
@danielgomezrico danielgomezrico changed the title Allow avoid-banned-imports to ignore show imports Allow avoid-banned-imports rule to ignore show imports Jan 19, 2024
@app-toolkit-opensource-innersource app-toolkit-opensource-innersource bot added the Review/Pending Initial stage of the issue to evaluate its approval label Jan 19, 2024

Assign to review: @santitigaga @ajtortolero

@danielgomezrico danielgomezrico changed the title Allow avoid-banned-imports rule to ignore show imports Allow avoid-banned-imports rule to ignore imports with specific show configuration Jan 19, 2024
@santitigaga santitigaga removed the Improvement New feature or request label Nov 18, 2024
@santitigaga
Copy link
Contributor

@danielgomezrico sorry fot the delay...
maybe will be useful to create a new rule for that something like only-allowed-import-members

You can contribute with this specific proposal if you like it

@santitigaga santitigaga added the Improvement New feature or request label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement New feature or request Review/Pending Initial stage of the issue to evaluate its approval
Projects
None yet
Development

No branches or pull requests

2 participants