New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitlab reporter does not generate proper json #169

Open

prasadsunny1 opened this issue Jan 26, 2025 · 1 comment

Labels

Error Review/Pending

prasadsunny1 commented Jan 26, 2025 •

edited

Loading

Describe the error
As per the official docs, the GitLab style should have an array of objects, but the DCL is generating something else.

I am running this "dart run dart_code_linter:metrics analyze . -r codeclimate --json-path gl-code-quality-report.json"

The output
gl-code-quality-report-mine.json

Runtime environment

OS: macos and on gitlab's official linux runner
Browser: [chrome, safari, firefox]
Version: 1.3.0

Upon looking at DCL code, I see that gitlab and codeclimate reporters are using same template,
a new reporter should be made for gitlab format as per the spec https://docs.gitlab.com/ee/ci/testing/code_quality.html#code-quality-report-format

Also, there is a pkg that promises to generate correct format : https://pub.dev/packages/flutter_analyze_reporter
Probably we can understand and adapt it. I will try that too and update the thread

prasadsunny1 added the Error label

app-toolkit-opensource-innersource bot added the Review/Pending label

app-toolkit-opensource-innersource bot commented Jan 26, 2025

Assign to review: @santitigaga @ajtortolero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment