Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up downloading #15

Open
bartekch opened this issue Feb 9, 2015 · 2 comments
Open

Speed up downloading #15

bartekch opened this issue Feb 9, 2015 · 2 comments

Comments

@bartekch
Copy link
Owner

bartekch commented Feb 9, 2015

Right now list of results grows incrementally. This could slow up thigs when bigger sets of judgments are involved, should be rebuilt to avoid incremental growth. Take advantage of prior knowledge of number of results.

@bartekch
Copy link
Owner Author

It looks like it wouldn't be necessary, because R doesn't copy all elements of list when it is extended. Tests showed that when a list of apropiate length is prellocated an increase in speed is insignificant compared to time needed solely to communicate in API. For instance when we download 20k judgments the time has decreased from 720s to 690s, so a little. Therefore this issue will be put aside.

@bartekch
Copy link
Owner Author

Reopening, just to remember

@bartekch bartekch reopened this Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant