Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking argument for correctness #4

Open
bartekch opened this issue Nov 28, 2014 · 3 comments
Open

Checking argument for correctness #4

bartekch opened this issue Nov 28, 2014 · 3 comments
Labels

Comments

@bartekch
Copy link
Owner

Should arguments be checked inside R in addition to checking in API? For example format of dates?

Pros:

  • API not always return error, when in fact query doesn't make sense or is ambiguous (for example API silently adds zeros in front of a year - "11-11-11" is treated as "0011-11-11" not "2011-11-11")
  • easier handling of error messages inside R
  • sometimes it is possible to guess what user wants despite some typos

Cons:

  • complete checking process has to be written
  • overriding API's behaviour may not be desired
@bartekch
Copy link
Owner Author

Personally would go for double-checking

@mbojan
Copy link
Contributor

mbojan commented Dec 2, 2014

In principle such double-checks are desirable, but I'd put it in the end of a TODO because the API is not stable enough at this moment.

@bartekch
Copy link
Owner Author

bartekch commented Feb 9, 2015

Almost completed in 965c6d9 , 333c4d1 , 2210dc4 , and others.
However issue is left open until stable API version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants