From 93ac10d7f7ee2376f8cc48287c0165f39e999bde Mon Sep 17 00:00:00 2001 From: Anton Tsapov Date: Tue, 29 Oct 2013 13:29:18 +0200 Subject: [PATCH] Make conditions more readable. --- lib/ssl_requirement.rb | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/ssl_requirement.rb b/lib/ssl_requirement.rb index aaa08e8..dccdb2d 100644 --- a/lib/ssl_requirement.rb +++ b/lib/ssl_requirement.rb @@ -100,10 +100,10 @@ def ssl_required? required = self.class.ssl_required_actions || [] except = self.class.ssl_required_except_actions - unless except - required.include?(action_name.to_sym) - else + if except !except.include?(action_name.to_sym) + else + required.include?(action_name.to_sym) end end @@ -177,11 +177,7 @@ def self.determine_host(host) end def determine_port_string(port) - unless port_normal?(port) - ":#{port}" - else - "" - end + port_normal?(port) ? '' : ":#{port}" end def port_normal?(port)