You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
description={`A ${componentType} to animate numbers. Dependency-free. Accessible. Customizable.`}
However, the package.json does not reflect that. I think it’s easy to dismiss the internal dependency on number-flow, but there is also a seemingly external dependency on esm-env
There are probably very good reasons for this, or this might just be an oversight, but I think either those reasons should be addressed or the "dependency-free" claim should be removed
Hi, thanks for bringing this up. I'm sure some people will disagree, but I give esm-env a pass here because to me it's more of a bundler hack than an external dependency. There's no trace of it left in the final bundle, and it makes the final bundle smaller rather than bigger because it helps bundlers eliminate the server-only or client-only code.
Hmm, perhaps this could be added to the very bottom of the limitations section or so. If one doesn’t recognize esm-env it’s not really obvious that it wouldn’t actually be used in the runtime
barvian
changed the title
Documentation: Address "dependency-free"
[Docs]: Address "dependency-free"
Jan 31, 2025
NumberFlow version
@number-flow/[email protected]
Framework version
[email protected]
Describe the bug and the steps to reproduce it
Currently, the documentation claims this package is dependency-free:
number-flow/site/src/pages/[...framework]/_Home.astro
Line 17 in 8eabf0f
However, the
package.json
does not reflect that. I think it’s easy to dismiss the internal dependency onnumber-flow
, but there is also a seemingly external dependency onesm-env
There are probably very good reasons for this, or this might just be an oversight, but I think either those reasons should be addressed or the "dependency-free" claim should be removed
Minimal reproduction
https://number-flow.barvian.me/
The text was updated successfully, but these errors were encountered: