From fb0e3817662c4a4e1807b23fd11ce132383cf60e Mon Sep 17 00:00:00 2001 From: Vishesh Sanghani Date: Wed, 18 Sep 2024 15:58:47 +0530 Subject: [PATCH 1/4] [PD-254370] : bv-fetch catch clear issue resolved --- lib/bvFetch/index.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/bvFetch/index.js b/lib/bvFetch/index.js index e7bf8b7..9a4c648 100644 --- a/lib/bvFetch/index.js +++ b/lib/bvFetch/index.js @@ -167,6 +167,10 @@ module.exports = function BvFetch ({ shouldCache, cacheName, cacheLimit }) { // Check if response is available in cache const newPromise = this.fetchFromCache(cacheKey) .then((cachedResponse) => { + if (!cachedResponse) { + this.cachedUrls.delete(cacheKey) + return Promise.resolve(null); + } // If response found in cache, return it if (cachedResponse) { return cachedResponse; From 642c6c59efb195dc1ae910c8ad6365e7174a7710 Mon Sep 17 00:00:00 2001 From: Vishesh Sanghani Date: Fri, 20 Sep 2024 11:53:56 +0530 Subject: [PATCH 2/4] Release 2.9.4 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7fe8885..18c5e85 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "bv-ui-core", - "version": "2.9.3", + "version": "2.9.4", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index ea04d02..1db57a0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "bv-ui-core", - "version": "2.9.3", + "version": "2.9.4", "license": "Apache 2.0", "description": "Bazaarvoice UI-related JavaScript", "repository": { From 75047841d2fe5965256b8a6715f105970ae14d5d Mon Sep 17 00:00:00 2001 From: Vishesh Sanghani Date: Wed, 25 Sep 2024 15:20:51 +0530 Subject: [PATCH 3/4] [PD-254370]: BV Fetch cache issue resolved --- lib/bvFetch/index.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/bvFetch/index.js b/lib/bvFetch/index.js index 9a4c648..c16310e 100644 --- a/lib/bvFetch/index.js +++ b/lib/bvFetch/index.js @@ -1,4 +1,3 @@ - /** * @fileOverview * Provides api response caching utilties @@ -133,7 +132,10 @@ module.exports = function BvFetch ({ shouldCache, cacheName, cacheLimit }) { .then((cache) => { return cache.match(cacheKey) .then((cachedResponse) => { - + if (!cachedResponse) { + this.cachedUrls.delete(cacheKey) + return Promise.resolve(null); + } const cachedTime = cachedResponse.headers.get('X-Bazaarvoice-Cached-Time'); const ttl = cachedResponse.headers.get('Cache-Control').match(/max-age=(\d+)/)[1]; const currentTimestamp = Date.now(); @@ -167,10 +169,6 @@ module.exports = function BvFetch ({ shouldCache, cacheName, cacheLimit }) { // Check if response is available in cache const newPromise = this.fetchFromCache(cacheKey) .then((cachedResponse) => { - if (!cachedResponse) { - this.cachedUrls.delete(cacheKey) - return Promise.resolve(null); - } // If response found in cache, return it if (cachedResponse) { return cachedResponse; From 761e62974e0413f23d66e7273ef2508d1ec0f21f Mon Sep 17 00:00:00 2001 From: Vishesh Sanghani Date: Wed, 25 Sep 2024 15:23:47 +0530 Subject: [PATCH 4/4] Release 2.9.5 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 18c5e85..8564ecd 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "bv-ui-core", - "version": "2.9.4", + "version": "2.9.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 1db57a0..e785a67 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "bv-ui-core", - "version": "2.9.4", + "version": "2.9.5", "license": "Apache 2.0", "description": "Bazaarvoice UI-related JavaScript", "repository": {