Skip to content

Commit 06192be

Browse files
tulsa-devVtiwari01
andauthored
Feature/codingstandard changes (#97)
* space added or removed as per coding-standard instruction * Unescaped output detectedUnescaped output detected resolved * tag @Package removed * tag @pakage removed * removed php shorttags * removed php shorttags * updated the short comments and spacess addition and removal * patch added * module version update * module version update * compile error * module version update * removing setup-data files * Data patches files converted of Setup files * removed the logger * version updated * Removed echo as per test result * updated the version * test commit * Test commit for version update * Updated for compatibility of 2.4.4 and php 8.1 * Updated for compatibility of 2.4.4 and php8.1 * Updated code changes as per varnish test report * Updated code changes as per varnish test report * Reverted the latest changes * cron issue resolution * updated for cron issue * as per compatiblity 2.4.5 Co-authored-by: Vivek Tiwari <[email protected]> Co-authored-by: Vtiwari01 <[email protected]>
1 parent 80d4b7d commit 06192be

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

Logger/Logger.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
use Bazaarvoice\Connector\Api\ConfigProviderInterface;
1212
use Exception;
1313
use Magento\Framework\App\State;
14+
use Monolog\DateTimeImmutable;
1415

1516
/**
1617
* Class Logger
@@ -71,10 +72,9 @@ public function debug($message, array $context = []): void
7172
* @param int $level
7273
* @param string $message
7374
* @param array $context
74-
*
7575
* @return bool
7676
*/
77-
public function addRecord($level, $message, array $context = []): bool
77+
public function addRecord(int $level, string $message, array $context = [], DateTimeImmutable $datetime = null): bool
7878
{
7979
if (is_array($message)) {
8080
$message = print_r($message, $return = true);

Model/XMLWriter.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,10 @@ public function writeElement($name, $content = null, $cdata = false): bool
2929
$this->startElement($name);
3030
$this->writeCdata($content);
3131
$this->endElement();
32+
return true;
3233
} else {
3334
parent::writeElement($name, $content);
35+
return true;
3436
}
3537
}
3638

@@ -45,8 +47,10 @@ public function writeRaw($content = null, $cdata = false): bool
4547
$content = trim((string)$content);
4648
if ($cdata) {
4749
$this->writeCdata($content);
50+
return true;
4851
} else {
4952
parent::writeRaw($content);
53+
return true;
5054
}
5155
}
5256
}

0 commit comments

Comments
 (0)