Skip to content

Commit e8369c8

Browse files
committed
Set incompatible_strict_action_env and announce_rc in CI
1 parent 1e17486 commit e8369c8

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

.bazelci/presubmit.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ buildifier:
3434
build_flags:
3535
- "--keep_going"
3636
- "--build_tag_filters=-integration-test"
37+
- "--announce_rc"
3738
test_targets:
3839
- "--"
3940
- "..."

.bazelrc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ build --incompatible_default_to_explicit_init_py
2020
# Ensure ongoing compatibility with this flag.
2121
common --incompatible_disallow_struct_provider_syntax
2222

23+
common --incompatible_strict_action_env
24+
2325
# Windows makes use of runfiles for some rules
2426
build --enable_runfiles
2527

examples/bzlmod/.bazelrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@ test --test_output=errors --enable_runfiles
77

88
# Windows requires these for multi-python support:
99
build --enable_runfiles
10+
build --incompatible_strict_action_env
1011
common:bazel7.x --incompatible_python_disallow_native_rules

tests/integration/custom_commands_test.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
import logging
1615
import unittest
1716

1817
from tests.integration import runner
@@ -21,7 +20,12 @@
2120
class CustomCommandsTest(runner.TestCase):
2221
# Regression test for https://github.com/bazel-contrib/rules_python/issues/1840
2322
def test_run_build_python_zip_false(self):
24-
result = self.run_bazel("run", "--build_python_zip=false", "//:bin")
23+
result = self.run_bazel(
24+
"run",
25+
"--build_python_zip=false",
26+
"--incompatible_strict_action_env=false",
27+
"//:bin",
28+
)
2529
self.assert_result_matches(result, "bazel-out")
2630

2731

0 commit comments

Comments
 (0)