scala_inlined_library #1753
Open
scala_inlined_library #1753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergelyfabian
force-pushed
the
scala_inlined_library
branch
from
027b10c to
dfe245b
Compare
Add a new rule to enable compiling scala code, that is not for macro definitions, but would be used in inlining (so ijar support should be disabled for it). You may need strict dependency checks (transitive dependencies not on the classpath) for code that is to be used in inlining. Till now one would need to use scala_macro_library for that, but it was recently switched to include all transitive dependencies on the compiler's classpath, hence strict dependencies are not enforced there. The new rule enables having both: a) code compiled for inlining b) strict dependency checks
gergelyfabian
force-pushed
the
scala_inlined_library
branch
from
dfe245b to
4de48e4
Compare
|
Added a basic test and documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new rule to enable compiling scala code, that is not for macro definitions, but would be used in inlining (so ijar support should be disabled for it).
You may need strict dependency checks (transitive dependencies not on the classpath) for code that is to be used in inlining. Till now one would need to use
scala_macro_libraryfor that, but it was recently switched to include all transitive dependencies on the compiler's classpath, hence strict dependencies are not enforced there.The new rule enables having both: a) code compiled for inlining b) strict dependency checks
If this direction is a good one, I can extend the PR with further necessary changes (e.g. tests).