Skip to content

Commit 75a11b2

Browse files
ssaradpjszumski
authored andcommitted
Add comments on alwayslink
1 parent 59ae3f4 commit 75a11b2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

rules/library.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1069,7 +1069,7 @@ def apple_library(
10691069
deps = deps + private_deps + private_dep_names,
10701070
defines = defines,
10711071
tags = tags_manual,
1072-
alwayslink = True,
1072+
alwayslink = True, # ensure symbols from any static deps are always included (see https://github.com/bazelbuild/rules_apple/issues/1938)
10731073
testonly = testonly,
10741074
features = features,
10751075
)
@@ -1124,7 +1124,7 @@ def apple_library(
11241124
defines = defines + objc_defines,
11251125
testonly = testonly,
11261126
features = features,
1127-
alwayslink = True,
1127+
alwayslink = True, # ensure symbols from any static deps are always included (see https://github.com/bazelbuild/rules_apple/issues/1938)
11281128
**kwargs
11291129
)
11301130
launch_screen_storyboard_name = name + "_launch_screen_storyboard"

0 commit comments

Comments
 (0)