Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Introduce Custom Field for BMC Power Status in Netbox-sync #379

Closed
sh0x opened this issue Mar 26, 2024 · 10 comments
Closed

Proposal: Introduce Custom Field for BMC Power Status in Netbox-sync #379

sh0x opened this issue Mar 26, 2024 · 10 comments
Labels
awaiting reply Awaiting reply from issue owner enhancement New feature or request
Milestone

Comments

@sh0x
Copy link

sh0x commented Mar 26, 2024

Issue

Currently, in Netbox-sync, the BMC power status is synchronized with the management status in Netbox. While Netbox's management status is designed for inventory provisioning purposes (Offline, Active, Planned, Staged, Failed, Inventory), it's being utilized by netbox-sync to represent the server power status.

https://github.com/bb-Ricardo/netbox-sync/blob/main/module/sources/check_redfish/import_inventory.py#L217

Proposal

I suggest implementing a custom field specifically for the BMC power status instead of repurposing the device management status field. This separation would maintain clarity and prevent the BMC power status from conflating with device management statuses.

Reasoning

By introducing a dedicated field for BMC power status, we ensure that both the server's operational state and its management status remain distinct and accurately represented within Netbox. This separation enhances clarity and avoids potential confusion or misinterpretation of device statuses.

Benefits

  1. Clarity: Users can easily differentiate between the server's power status and its management status, facilitating better understanding and management of devices.
  2. Flexibility: Having a custom field allows for future expansions or modifications specific to BMC power status without impacting other aspects of device management.
  3. Consistency: Adhering to Netbox's intended use of management status promotes consistency across the platform and aligns with established conventions.

Conclusion

By implementing a dedicated field for BMC power status, we can enhance the clarity and maintain the integrity of device management within Netbox, ensuring a more intuitive and efficient experience for users.

@bb-Ricardo
Copy link
Owner

Hi,

This sounds reasonable, will try to change this behavior as described.

@bb-Ricardo bb-Ricardo added this to the v1.8.0 milestone Feb 20, 2025
@bb-Ricardo bb-Ricardo added awaiting reply Awaiting reply from issue owner enhancement New feature or request labels Feb 20, 2025
@bb-Ricardo
Copy link
Owner

Hi @sh0x,

really sorry, it's almost a year. But I finally pushed a change which implements exactly this behaviour.

Would be happy if you could try the development branch and see if this is what you expected (if you even still use this repo).

@sh0x
Copy link
Author

sh0x commented Mar 13, 2025

It works great, thanks for implementing it!

@bb-Ricardo
Copy link
Owner

Are you actually working at VMware?

@sh0x
Copy link
Author

sh0x commented Mar 13, 2025

Yes I'm still there :)

@bb-Ricardo
Copy link
Owner

I just read that more then half of the employees have been booted sincethe takeover, which is crazy.

So you're telling me that VMware itself is using this project?

@sh0x
Copy link
Author

sh0x commented Mar 13, 2025

I'm using check_redfish and netbox-sync to sync redfish data for ~1,500 servers we manage (Dell, HP, Lenovo), works great!

@bb-Ricardo
Copy link
Owner

bb-Ricardo commented Mar 13, 2025

Wow, great to hear. Didn't anticipate this when I started this project 😅. And these days, both projects are just a hobby of mine as I shifted my work focus.

@patschi
Copy link

patschi commented Mar 13, 2025

Didn't anticipate this when I started this project 😅.

I've heard from multiple customers/friends using your project in their companies; it's a really valuable addition to netbox. I'm personally using it for my HomeLab and helps me to keep an overview (let's say, the lab "it escalated quickly"...)

But also interesting to hear that VMware/Broadcom is using it too. Definitely an achievement - but honestly well deserved!

@bb-Ricardo
Copy link
Owner

Didn't anticipate this when I started this project 😅.

I've heard from multiple customers/friends using your project in their companies; it's a really valuable addition to netbox. I'm personally using it for my HomeLab and helps me to keep an overview (let's say, the lab "it escalated quickly"...)

But also interesting to hear that VMware/Broadcom is using it too. Definitely an achievement - but honestly well deserved!

Thank you for the kind words. It's great to here that people appreciate this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reply Awaiting reply from issue owner enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants