From 96ba292dcdca70712e719f440c49854cbfd1195d Mon Sep 17 00:00:00 2001 From: braks <78412429+bcakmakoglu@users.noreply.github.com> Date: Fri, 14 Mar 2025 14:54:32 +0100 Subject: [PATCH 1/3] revert(core): remove defer of connection lookup update Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com> --- packages/core/src/store/actions.ts | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/packages/core/src/store/actions.ts b/packages/core/src/store/actions.ts index a88412282..ccf853546 100644 --- a/packages/core/src/store/actions.ts +++ b/packages/core/src/store/actions.ts @@ -1,6 +1,5 @@ import { zoomIdentity } from 'd3-zoom' import type { ComputedRef } from 'vue' -import { nextTick } from 'vue' import { until } from '@vueuse/core' import type { Actions, @@ -532,13 +531,9 @@ export function useActions(state: State, nodeLookup: ComputedRef, ed state.edges, ) - nextTick(() => { - state.edges = state.edges.map((edge, index) => (index === prevEdgeIndex ? validEdge : edge)) + state.edges = state.edges.map((edge, index) => (index === prevEdgeIndex ? validEdge : edge)) - nextTick(() => { - updateConnectionLookup(state.connectionLookup, edgeLookup.value, [validEdge]) - }) - }) + updateConnectionLookup(state.connectionLookup, edgeLookup.value, [validEdge]) return validEdge } From 6ff4fc033710c6b2f849f02b6c2db3527dc95ba4 Mon Sep 17 00:00:00 2001 From: braks <78412429+bcakmakoglu@users.noreply.github.com> Date: Fri, 14 Mar 2025 14:54:53 +0100 Subject: [PATCH 2/3] fix(core): remove edge lookup update when updating connection lookup Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com> --- packages/core/src/utils/store.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/core/src/utils/store.ts b/packages/core/src/utils/store.ts index eb8f28312..349c98dee 100644 --- a/packages/core/src/utils/store.ts +++ b/packages/core/src/utils/store.ts @@ -165,7 +165,6 @@ function addConnectionToLookup( export function updateConnectionLookup(connectionLookup: ConnectionLookup, edgeLookup: EdgeLookup, edges: GraphEdge[]) { connectionLookup.clear() - edgeLookup.clear() for (const edge of edges) { const { source: sourceNode, target: targetNode, sourceHandle = null, targetHandle = null } = edge @@ -176,8 +175,6 @@ export function updateConnectionLookup(connectionLookup: ConnectionLookup, edgeL addConnectionToLookup('source', connection, targetKey, connectionLookup, sourceNode, sourceHandle) addConnectionToLookup('target', connection, sourceKey, connectionLookup, targetNode, targetHandle) - - edgeLookup.set(edge.id, edge) } } From 92f888f059569c6ddbc1dc8c4b4875be0d564cd8 Mon Sep 17 00:00:00 2001 From: braks <78412429+bcakmakoglu@users.noreply.github.com> Date: Fri, 14 Mar 2025 14:55:33 +0100 Subject: [PATCH 3/3] chore(changeset): add Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com> --- .changeset/many-donkeys-train.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/many-donkeys-train.md diff --git a/.changeset/many-donkeys-train.md b/.changeset/many-donkeys-train.md new file mode 100644 index 000000000..55ebf7620 --- /dev/null +++ b/.changeset/many-donkeys-train.md @@ -0,0 +1,5 @@ +--- +"@vue-flow/core": patch +--- + +Remove edgelookup update when updating connection lookup as edge lookup is computed already