Skip to content

Commit c19bc72

Browse files
authored
chore(ci): remove merge queues (#1783)
1 parent fddf4ba commit c19bc72

File tree

3 files changed

+6
-29
lines changed

3 files changed

+6
-29
lines changed

.github/workflows/analysis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ name: Analysis
33
on:
44
push:
55
branches: [main]
6-
merge_group:
76
pull_request:
87
types: [opened, reopened, synchronize, ready_for_review, converted_to_draft]
98
schedule:

.github/workflows/pr-open.yml

Lines changed: 6 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,23 @@ name: PR
22

33
on:
44
pull_request:
5-
merge_group:
65

76
concurrency:
8-
# Cancel in progress for PR open and close, but not merge_group
9-
group: ${{ github.workflow }}-${{ github.event.number || github.event.merge_group.base_sha }}
7+
# Cancel in progress for PR open and close
8+
group: ${{ github.workflow }}-${{ github.event.number }}
109
cancel-in-progress: true
1110

1211
jobs:
13-
# PR only, skip for merge_group
1412
conventional-commits:
1513
name: Conventional Commits
16-
if: github.event_name == 'pull_request'
1714
runs-on: ubuntu-22.04
1815
steps:
1916
- uses: amannn/[email protected]
2017
env:
2118
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2219

23-
# PR only, skip for merge_group
2420
pr-description-add:
2521
name: PR Description Add
26-
if: github.event_name == 'pull_request'
2722
env:
2823
DOMAIN: apps.silver.devops.gov.bc.ca
2924
PREFIX: ${{ github.event.repository.name }}
@@ -49,22 +44,9 @@ jobs:
4944
After merge, new images are deployed in:
5045
- [Merge Workflow](https://github.com/${{ github.repository }}/actions/workflows/merge.yml)
5146
52-
# Find initial PR number (for merge queues)
53-
vars:
54-
name: Set Variables
55-
outputs:
56-
pr: ${{ steps.pr.outputs.pr }}
57-
runs-on: ubuntu-22.04
58-
steps:
59-
# Get PR number for merge queues, otherwise use github.event.number
60-
- name: PR Number
61-
id: pr
62-
uses: bcgov-nr/[email protected]
63-
6447
# https://github.com/bcgov-nr/action-builder-ghcr
6548
builds:
6649
name: Builds
67-
needs: [vars]
6850
runs-on: ubuntu-22.04
6951
permissions:
7052
packages: write
@@ -77,19 +59,19 @@ jobs:
7759
with:
7860
keep_versions: 50
7961
package: ${{ matrix.package }}
80-
tag: ${{ needs.vars.outputs.pr }}
62+
tag: ${{ github.event.number }}
8163
tag_fallback: latest
8264
triggers: ('${{ matrix.package }}/')
8365

8466
# https://github.com/bcgov-nr/action-deployer-openshift
8567
deploys:
8668
name: Deploys
87-
needs: [builds, vars]
69+
needs: [builds]
8870
uses: ./.github/workflows/.deploy.yml
8971
secrets: inherit
9072
with:
9173
autoscaling: false
9274
directory: charts/quickstart-openshift
93-
tag: ${{ needs.vars.outputs.pr }}
94-
release: ${{ needs.vars.outputs.pr }}
75+
tag: ${{ github.event.number }}
76+
release: ${{ github.event.number }}
9577
triggers: ('backend/' 'frontend/' 'migrations/' 'charts/')

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -238,10 +238,6 @@ This is required to prevent direct pushes and merges to the default branch. The
238238

239239
![](./.graphics/branch-protection.png)
240240

241-
### Merge Queues
242-
243-
Queues allow PRs to be merged without being fully up-to-date. From the queue they are updated against the default branch and the PR workflow is re-run. This is useful for large teams or repositories with long-running workflows, but generally discouraged.
244-
245241
### Adding Team Members
246242

247243
Don't forget to add your team members!

0 commit comments

Comments
 (0)